fix: Change the plugin version specification method#121
Conversation
Summary of ChangesHello @riscait, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the integration method for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the plugin version specification method from using a local path to a version, which is a good improvement for package consumers. The changes are consistent across the pubspec.yaml, CHANGELOG.md, and configuration files. The documentation in README.md has been updated accordingly, but it now includes a hardcoded version number which could be difficult to maintain. I've suggested using a placeholder instead. Additionally, there's a nice refactoring in lib/main.dart that improves code conciseness by using forEach on a list to register lint rules.
| include: package:altive_lints/altive_lints.yaml | ||
| plugins: | ||
| altive_lints: | ||
| version: ^2.0.0-dev.3 |
There was a problem hiding this comment.
Hardcoding the version number in the documentation can become a maintenance burden, as it will need to be updated with every new release. To avoid this, consider using a placeholder like <latest_version> and instructing users to find the latest version on pub.dev.
| version: ^2.0.0-dev.3 | |
| version: <latest_version> |
|
|
||
| plugins: | ||
| altive_lints: | ||
| version: ^2.0.0-dev.3 |
🙌 What's Done
✍️ What's Not Done
Pre-launch Checklist