Add tests for {modernbert,laya}.rs with insta - #12
Merged
Merged
Conversation
alvarobartt
changed the title
{modernbert,laya}.rs with insta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
instadependency for snapshot testing in order to add tests for bothmodernbert.rsandlaya.rsto ensure that no regressions are introduced and that the outputs match across devices (when using the same precision) within a certain tolerance.Additionally, this PR also updates the GitHub Actions to run the tests as a separate action only after the linting is passing, and only build the containers once the tests are passing (same for publishing); mostly to be mindful with the minutes used for each runner.