FIX for a commit without a PR! - Orginal: Add GitHub Release workflow and update related files - #168
Merged
Conversation
Collaborator
Author
|
To see, how such a release will look like: https://github.com/Martinius79/EleksTubeHAX/releases These are TEST releases and they will be deleted. And they are based on the created tags. so v1.3.10-test3, v1.3.10-test4, v1.3.10-test5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally merged a branch into main without creating a PR!
I’m very sorry about that!
I didn’t realize the upstream was pointing to the original repository.
The files now only contain whitespace changes in the first line, just to indicate that they have been modified.
The files are already changed! So I try to describe the changes exactly here.
Here is the originally planned PR comment:
Add GitHub Release workflow and update related files
Motivation
Previously there was no automated way to create an official GitHub Release with firmware binaries attached. Firmware updates were only available as temporary GitHub Actions artifacts — these expire after 90 days, require a GitHub login to download, and are buried under workflow run pages that are not user-friendly. There was no stable, public download link to share with users.
This PR introduces a dedicated release workflow that produces permanent, publicly accessible downloads via the GitHub Releases page, while cleaning up the responsibilities of the existing workflows.
What changed
New:
.github/workflows/pio-build-and-create-github-release.ymlA new workflow that:
v*, e.g.v1.3.10) or manually viaworkflow_dispatchwith a custom tag name.platformio.ini— no manual list to maintain.ubuntu-latest, withCREATE_FIRMWAREFILEenabled so the full merged binary (FW_*.bin— app + filesystem + bootloader) is produced.FW_*.binfiles as individual per-environment artifacts and then merges them in thereleasejob.firmware/README.mdfor detailed flashing guidancegh release create, attaching allFW_*.binfiles directly. Tags matching*-rc*,*-beta*or*-alpha*are automatically marked as pre-release.Modified:
.github/workflows/pio-build-and-publish-all-firmware-files.ymlpush: branches: [main]trigger — this workflow no longer runs on every commit tomain. Continuous release publishing is now the job of the new release workflow.pull_requestandworkflow_dispatchtriggers so the workflow still serves as a build-check for PRs and can be triggered manually. Comments in the YAML clarify this intent.checkout@v4→v6,setup-python@v5→v6,upload-artifact@v4→v7,download-artifact@v4→v8.Modified:
.github/workflows/pio-build-multi-platform.ymlwindows-latesttowindows-2025-vs2026with an explanatory comment, becausewindows-latestwill be deprecated by June 2026.checkout@v4→v6,setup-python@v5→v6.Modified:
README.md(section 4.3)Modified:
firmware/README.md(section 5)GitHubActionsOverview.png,GitHubActionsArtifactView.png).Why this is better than before
github.com/.../releasesmain(noisy)windows-latest(deprecated June 2026)windows-2025-vs2026