feat(Simple Subscription): optionally add additional customer info

[HenningWendtland]

Business Case:
The customer does not have a unique Billing Address, Contact or Shipping Address. This feature allows the user to select one in the Simple Subscription that gets forwarded into the Sales Invoice.

Implementation Details:

• 3 Link fields + Display of Address / Contact in virtual fields
• Validation that links match the Customer on every save
• Fields are optional and have allow_on_submit, so they can be filled after submission also

Tested:

• Fields exist and Data is carried through to the Sales Invoice as expected
• Virtual fields are rendered correctly
• Values do not interfere with ERPNext tax logic (Address is set first, so Tax Rules use the one provided)

[greptile-apps]

Confidence Score: 5/5

The implementation appears safe to merge, although invoice forwarding remains covered only indirectly by metadata assertions.

The outstanding previous test-coverage finding remains unresolved because the revised tests still never invoke create_invoice, so ordering regressions between explicit address assignment, set_missing_values(), and contact overriding can pass CI; this is non-blocking coverage feedback. The other four previous findings were manually resolved without explanation.

Files Needing Attention: simple_subscription/simple_subscription/doctype/simple_subscription/test_simple_subscription.py

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  C[Customer] --> S[Simple Subscription]
  A[Selected billing address] --> S
  H[Selected shipping address] --> S
  P[Selected contact] --> S
  S --> V{Links belong to customer?}
  V -->|No| E[Reject save or post-submit update]
  V -->|Yes| I[Create Sales Invoice]
  I --> D[Apply missing customer defaults]
  D --> O[Override default contact when selected]

Loading

_{Reviews (4): Last reviewed commit: "fix: remove commit from tests and add ad..." | Re-trigger Greptile}