Skip to content

fix: set values to None so set_missing_values works #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barredterra merged 2 commits into from
Sep 8, 2026
+4 −3
Merged

fix: set values to None so set_missing_values works #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cb26e8
fix: fix empty additional info in address
HenningWendtland Sep 8, 2026
223d08f
fix: simplify syntax and add taxes case that surfaced
HenningWendtland Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions simple_subscription/simple_subscription/doctype/simple_subscription/simple_subscription.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,9 @@ def create_invoice(self, from_date: date, to_date: date) -> SalesInvoice:
invoice = frappe.new_doc("Sales Invoice")
invoice.company = self.company
invoice.customer = self.customer
invoice.customer_address = self.customer_address
invoice.shipping_address_name = self.shipping_address_name
# '' is not None, so update_if_missing() in set_missing_values() would keep it and skip the default
invoice.customer_address = self.customer_address or None
invoice.shipping_address_name = self.shipping_address_name or None
invoice.selling_price_list = self.get_price_list()
for row in self.items:
invoice.append(
Expand All @@ -125,7 +126,7 @@ def create_invoice(self, from_date: date, to_date: date) -> SalesInvoice:
"qty": row.qty,
},
)
invoice.taxes_and_charges = self.taxes_and_charges
invoice.taxes_and_charges = self.taxes_and_charges or None
Comment thread
HenningWendtland marked this conversation as resolved.
invoice.from_date = from_date
invoice.to_date = to_date
invoice.simple_subscription = self.name
Expand Down
Loading