Skip to content

fix(control): preserve plain symbol key levels #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bvolpato merged 1 commit into from
Aug 1, 2026
Merged

fix(control): preserve plain symbol key levels #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust/limux-host-linux/src/terminal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2125,7 +2125,7 @@ fn translated_keyval_for_keycode(
keycode: u32,
modifier: gtk::gdk::ModifierType,
) -> gtk::gdk::Key {
if keycode == 0 {
if keycode == 0 || !modifier.contains(gtk::gdk::ModifierType::SHIFT_MASK) {
return keyval;
}

Expand Down
7 changes: 4 additions & 3 deletions scripts/xvfb-smoke-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ grep -Fq "$SCREEN_PROOF" "$LOG_DIR/stage1-screen.txt" \

SHIFTED_KEY_PROOF="$DEMO_DIR/shifted-key-proof"
"$LIMUX_CLI" send --workspace limux "printf '" >"$LOG_DIR/stage1-shifted-prefix.txt"
"$LIMUX_CLI" send-key --workspace limux at >"$LOG_DIR/stage1-plain-symbol.txt"
"$LIMUX_CLI" send-key --workspace limux '<Shift>a' >"$LOG_DIR/stage1-shifted-letter.txt"
"$LIMUX_CLI" send-key --workspace limux '<Shift>1' >"$LOG_DIR/stage1-shifted-symbol.txt"
"$LIMUX_CLI" send --workspace limux "' > '$SHIFTED_KEY_PROOF'" >"$LOG_DIR/stage1-shifted-suffix.txt"
Expand All @@ -282,9 +283,9 @@ for _ in $(seq 1 50); do
[ -f "$SHIFTED_KEY_PROOF" ] && break
sleep 0.1
done
[ "$(cat "$SHIFTED_KEY_PROOF" 2>/dev/null)" = 'A!' ] \
|| { echo "FAIL: shifted send-key did not produce A!"; exit 1; }
echo "stage 1b: OK (surface realized, terminal I/O and shifted keys verified)"
[ "$(cat "$SHIFTED_KEY_PROOF" 2>/dev/null)" = '@A!' ] \
|| { echo "FAIL: plain and shifted send-key did not produce @A!"; exit 1; }
echo "stage 1b: OK (surface realized, terminal I/O and key levels verified)"

# --- 5. Stage 2: live agent-team ------------------------------------------
echo
Expand Down
Loading