fix(host): restore terminal links and window controls - #146
Draft
gmanvelian wants to merge 1 commit into
Draft
Conversation
bvolpato
reviewed
Aug 13, 2026
| } | ||
| } | ||
|
|
||
| fn open_url_in_external_browser(url: &str) { |
Collaborator
There was a problem hiding this comment.
Would it make sense to keep the existing http/https/mailto allow-list here, or add an explicit confirmation for other schemes? Terminal output can control OSC 8 links, so this now sends file://, GVFS, and custom application schemes straight to GIO/xdg-open. Is that a concern?
bvolpato
reviewed
Aug 13, 2026
| let header = if provides_decorations { | ||
| None | ||
| } else { | ||
| // Always render the header bar. `adw::ApplicationWindow` installs its own |
Collaborator
There was a problem hiding this comment.
Could we rebase this on current main and preserve KWin server-side decoration path? main now requests server-side decorations after present(), while this block always forces client-side decorations and currently conflicts with that code. Is losing that KWin behavior a concern?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
docs/session-logs/2026-08-10-terminal-links-and-window-controls.md.Why
Terminal links could become inert when a user Ghostty configuration did not define an
open_urlbinding. Separately, on Wayland compositors that advertisezxdg_decoration_manager_v1(notably KWin/Plasma), Limux suppressed its header even though libadwaita had already selected client-side decorations, leaving no window controls.Validation
cargo fmt --checkLD_LIBRARY_PATH=ghostty/zig-out/lib cargo test -p limux-host-linux(227 passed)cargo clippy -p limux-host-linux -- -D warningscargo build --release -p limux-host-linux --bin limux