Redesign top bar + sidebar, add settings (#5)

[mvbmir]

Summary

Implements the cmux-style top bar and sidebar redesign plus three related settings and the split-ratio fix. Single commit against main.

Top bar

Custom top bar at the top of the window: sidebar toggle, settings cog, "+" new-workspace button, a row of workspace indicator pills, and the window controls (minimize/maximize/close). Empty space drags the window via gtk::WindowHandle. The window controls are plain gtk::Buttons rather than gtk::WindowControls so their hover shape and sizing match the rest of the icons.

Pane header

• Empty space between the last tab and the action icons is a WindowHandle filler — drags the window without conflicting with the tabs' DragSource.
• Middle-click on a tab closes it.
• Settings cog moved out of the per-pane action row and into the top bar, freeing horizontal tab space.

Sidebar

• Each row has a close X on the top-right (replaces the old star slot). Star moved below next to the folder path; both are hover-to-reveal 20×20 buttons.
• Double-click a workspace row to inline-rename.
• Accent-tinted selected-row background; first-row top margin matches the between-workspace gap.
• No more "WORKSPACES" title or big bottom "+" button.

New-workspace UX

• Clicking "+" clones the active workspace's folder. The folder picker only appears on first run / when no workspace exists.

Settings → General (three new rows)

• Top bar (switch) — when off, the top bar is removed entirely. Its buttons relocate into a new sidebar header (sidebar open) or onto the active workspace's leading pane (sidebar collapsed). Sidebar-header layout puts the app buttons on one end and the window controls on the other with an hexpand spacer between.
• Window controls side (Left / Right) — moves minimize/maximize/close between the two ends of whichever header is active.
• Workspace indicators on the top bar (switch) — hides the pills without hiding the top bar. Implementation hides each pill individually so indicator_box keeps its hexpand spacer role.
• All three persist under interface.* in settings.json. Defaults: show_top_bar = true, show_workspace_indicators = true, window_controls_side = Right — upgrading users see the familiar layout.

Split ratio fix

• shrink_start_child / shrink_end_child on every gtk::Paned so the saved ratio wins over larger child minimums (e.g. a wide tab strip).
• position-notify now tracks last_size: width changed → auto-adjust (don't touch ratio); width unchanged → real user drag (update ratio). Fixes the silent 0.5 → 0.6 drift that happened when the sidebar toggled or the window resized — GtkPaned::position is absolute pixels, so the old handler computed a different ratio each time the paned's width changed.
• Per-frame tick callback observes the paned's actual width and re-applies position = ratio × new_width on size changes. GtkWidget::width / height don't reliably emit notify across GTK 4.x versions, so polling is intentional; the check is O(1) with early return.
• Startup uses a one-shot tick callback to apply the ratio once the paned first has a non-zero allocation.

Structural

• handle_config_change() dedupes the appearance + top-bar side-effect + save/revert logic that ran from two config-change sites.
• apply_top_bar_mode() is the single source of truth for how the dock toggle, settings cog, +, indicator pills, and window controls are laid out — respects both the persistent show_top_bar setting and the transient keyboard toggle.
• Widget tree walkers (is_pane_widget, find_leaf_focused_pane) unwrap gtk::WindowHandle so the dock-parked-on-pane layout still resolves panes correctly.

Closes #5 (notifications explicitly out of scope per the issue).

Notes for reviewers

• The add_tick_callback polling in split_tree.rs is intentional. GTK 4.x doesn't reliably emit notify on width/height, so the signal-driven approach silently misses resize events; the tick loop catches them at the cost of one integer compare per frame.
• gtk::WindowControls is replaced by three plain gtk::Buttons wired to window.minimize() / maximize() / close(). Adwaita's default 24 px circular styling couldn't be cleanly overridden to match the other top-bar icons.

Test plan

• cargo fmt clean
• cargo clippy --release -- -D warnings clean
• cargo test — all 181 unit tests pass
• Manual: top bar on/off, sidebar open/closed, left/right controls — all combinations
• Manual: workspace indicators on/off toggles the pills; window controls stay at the right edge regardless
• Manual: middle-click tab close, last tab closes pane, last pane closes workspace
• Manual: split ratio stable across sidebar toggles and window resizes
• Manual: double-click inline rename, folder clone on "+"

[mvbmir]

@am-will Apologies for the big PR, adding a top bar is opinionated design wise, considering you don't have one, but since I really felt the need for it, I added it as an optional UI part.

So, for people who like the no top bar, they can keep the dock only, with slight improvements.

There's also some other quality of life things like closing tabs with middle mouse button, making the pane bars drag the window also, some button designs, etc, so if you see anything you'd like me to separate into a different PR let me know.

[am-will]

I will take a look when I can ty

[mvbmir]

Hi @am-will, did you end up taking a look?

[am-will]

My fault dude I got sick. I'll check later

…

On Tue, May 5, 2026, 11:42 AM MVB.Mir ***@***.***> wrote: *mvbmir* left a comment (am-will/limux#62) <#62 (comment)> Hi @am-will <https://github.com/am-will>, did you end up taking a look? — Reply to this email directly, view it on GitHub <#62 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKD57ZFEDUN6BQ2I62NDW6D4ZIRXDAVCNFSM6AAAAACX5DIATSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGOBRGYZTAOJQGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[am-will]

let me merge some other issues and i'll get to this. looks interesting for sure

[bvolpato]

Great redesign and implementation quality. I ran local verification after fixing the missing ghostty dependency artifact (git submodule update --init --recursive ghostty and cd ghostty && zig build -Dapp-runtime=none -Doptimize=ReleaseFast), then reran gates: cargo test and cargo clippy --release -- -D warnings, both clean. Left 3 inline non-blocking suggestions for maintainability/resilience. Approving.

[mvbmir]

@bvolpato Thanks for the review!

@am-will Sorry for also disappearing for a bit, had my own fare share of health issues to deal with for a while. Let me know if this can go in with the rebase and the fixes applied, or if you'd like some changes to anything!

[bvolpato]

Strong UI direction. Config compatibility, centralized layout handling, indicator lifecycle, and settings rollback look solid.

Current head needs attention before merge:

• split_tree.rs:463 enables child shrinking, then immediately disables both flags. Saved ratios still lose against child minimums.
• split_tree.rs:503 consumes size changes in position-notify, preventing tick callback from reapplying ratio afterward. Resize-driven drift remains when GTK emits that notification.
• window.rs:1771 leaves drag/drop controller on hidden sidebar button. Visible top-bar + has click handling only, breaking tab drag into new workspace and workspace drag-delete target.
• window.rs:1694 always renders custom top bar, removing current Wayland xdg-decoration guard and causing stacked compositor/app chrome on affected desktops.

PR also conflicts with current main in config, settings, and window code. Rebase must retain newer interface-scale, terminal shortcut, browser lifecycle, session shutdown, and tab-rename fixes.

Latest GitHub quality check is green. Reviewed all five changed files; isolated Ghostty build passed. Full local gate was interrupted before completion.

Recommendation: COMMENT. Rebase and fix blockers before approval.

(Review assisted by gpt-5.6-sol)

[bvolpato]

Latest commits fix both split-ratio findings: child shrinking stays enabled and resize notifications no longer consume size changes before tick reapply. Two blockers remain:

• window.rs:1766-1792 attaches drag/drop only to hidden sidebar new_ws_btn; visible top-bar + has click handling only, so tab-drop-to-new-workspace and workspace drag-delete lose their target
• custom WindowHandle header is now unconditional, removing current main's Wayland zxdg_decoration_manager_v1 guard and causing duplicate app/compositor chrome where server-side decorations exist

Branch also conflicts with newer unread-tab, tab-rename, Unicode-title, and tab-drop work. Please rebase and preserve those behaviors.

Quality check is green.

(assisted by gpt-5.6-sol)

[mvbmir]

@bvolpato rebased onto latest main and fixed all four blockers

• split_tree.rs shrink flags: kept shrink_start/end_child enabled, the set_shrink_*_child(false) right after was undoing it, so a saved 50/50 ratio now holds instead of losing to the wider pane's minimum
• split_tree.rs position-notify: it no longer writes last_size, so the per-frame tick still re-applies position = ratio * width after a resize (no more resize-driven drift)
• top-bar + drag/drop: extracted install_workspace_dnd_target and wired it onto the visible top-bar button, so tab-drag-into-new-workspace and workspace drag-delete work again (they were stuck on the hidden sidebar button)
• xdg-decoration: restored the guard, on Wayland compositors that provide server-side decorations the custom min/max/close are hidden so they don't stack on the compositor's controls

retained the newer interface-scale / show-workspace-path / tab-rename / etc from main, ui_scale + path visibility now live-apply through handle_config_change since settings moved to the top bar. gate green (fmt + clippy -D warnings + tests)

mind taking another look when you get a sec?

[mvbmir]

@bvolpato bumping, all 4 blockers fixed + rebased onto latest main, CI green, ready for another look when you get a sec

[am-will]

Got any screenshots?

[bvolpato]

The Aug 7 update fixes all four previous blockers: split shrink flags, resize-ratio handling, top-bar workspace DnD, and the decoration guard. Exact-head quality and GTK smoke checks pass. Two current P1s remain:

1. window.rs sync_top_bar_visibility() uses only transient top_bar_visible plus fullscreen state. It ignores config.interface.show_top_bar. With the Top bar setting disabled, leaving fullscreen can make the WindowHandle visible again without restoring its reparented controls, producing a blank or incorrect top bar. Include persisted visibility or rerun apply_top_bar_mode() on fullscreen transitions.

2. split_tree.rs persistent tick callback is owned by paned but captures paned.clone() as paned_for_resize. That creates a strong self-cycle and leaks every old GtkPaned after split-tree rebuilds. Use the callback paned argument at apply_ratio_value(), or capture a weak reference.

Nonblocking: the three new settings controls do not resync from the effective config after save failure, so widgets can display rejected values after state and layout roll back.

After these fixes, rebase or adapt the decoration path after #142 because both branches currently conflict in window.rs. Thanks for addressing the previous review thoroughly.