Skip to content

feat(terminal): persist font size per terminal tab - #98

Open
atacolak wants to merge 1 commit into
am-will:mainfrom
atacolak:feat/per-terminal-font-size
Open

feat(terminal): persist font size per terminal tab#98
atacolak wants to merge 1 commit into
am-will:mainfrom
atacolak:feat/per-terminal-font-size

Conversation

@atacolak

@atacolak atacolak commented Jun 4, 2026

Copy link
Copy Markdown

summary

  • make terminal font-size shortcuts operate on the focused terminal tab only
  • persist per-terminal-tab font-size overrides in session state
  • keep app-level font_size as the default for terminals without an override
  • preserve backwards compatibility with old session json that lacks font_size

why

currently ctrl++, ctrl+-, and reset behave globally: changing one terminal changes every live terminal surface. in a split workspace this is surprising because each terminal tab is visually independent and often has different content density needs.

this patch stores font-size override state on each terminal tab and applies ghostty font-size actions only to the focused terminal surface.

testing

  • cargo fmt --check
  • cargo check -p limux-host-linux
  • cargo test -p limux-host-linux
  • cargo test --workspace
  • cargo clippy --workspace --all-targets -- -D warnings
  • ./scripts/check.sh
  • manual gui check: two terminal panes can be set to different font sizes without changing each other

@atacolak

atacolak commented Jun 6, 2026

Copy link
Copy Markdown
Author
image

@atacolak

atacolak commented Jul 4, 2026

Copy link
Copy Markdown
Author

@am-will o.0?

@bvolpato bvolpato left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR logic looks sound on original base, including per-tab persistence, legacy JSON handling, focused-surface updates, and finite/clamped sizes.

Current head is not merge-ready: it conflicts with main in pane.rs, where recent terminal callback/options work overlaps this patch. Please rebase, preserve clipboard callback/environment changes alongside font-size state, then rerun checks.

(Review assisted by gpt-5.6-sol)

@bvolpato bvolpato left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per-tab font-size persistence logic is sound on original base, including legacy session handling and finite/clamped values. Current head conflicts with newer pane callback, terminal environment, and tab lifecycle work.

Please rebase onto current main, preserve newer callback/environment behavior, and rerun quality gate before approval.

(assisted by gpt-5.6-sol)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants