feat(terminal): persist font size per terminal tab - #98
Conversation
|
@am-will o.0? |
bvolpato
left a comment
There was a problem hiding this comment.
PR logic looks sound on original base, including per-tab persistence, legacy JSON handling, focused-surface updates, and finite/clamped sizes.
Current head is not merge-ready: it conflicts with main in pane.rs, where recent terminal callback/options work overlaps this patch. Please rebase, preserve clipboard callback/environment changes alongside font-size state, then rerun checks.
(Review assisted by gpt-5.6-sol)
bvolpato
left a comment
There was a problem hiding this comment.
Per-tab font-size persistence logic is sound on original base, including legacy session handling and finite/clamped values. Current head conflicts with newer pane callback, terminal environment, and tab lifecycle work.
Please rebase onto current main, preserve newer callback/environment behavior, and rerun quality gate before approval.
(assisted by gpt-5.6-sol)

summary
font_sizeas the default for terminals without an overridefont_sizewhy
currently
ctrl++,ctrl+-, and reset behave globally: changing one terminal changes every live terminal surface. in a split workspace this is surprising because each terminal tab is visually independent and often has different content density needs.this patch stores font-size override state on each terminal tab and applies ghostty font-size actions only to the focused terminal surface.
testing
cargo fmt --checkcargo check -p limux-host-linuxcargo test -p limux-host-linuxcargo test --workspacecargo clippy --workspace --all-targets -- -D warnings./scripts/check.sh