[caveman] Optimize instruction verbosity — contribution-checker.agent.md (2026-05-31)#3123
Conversation
There was a problem hiding this comment.
Pull request overview
This PR streamlines the contribution checker agent instructions by removing duplicated introductory text and tightening the comment guidance/examples while preserving the agent’s evaluation rules and output schema.
Changes:
- Removed redundant title/description already covered by frontmatter.
- Condensed comment-field requirements and
needs-workexample wording. - Preserved verdict rules, checklist fields, JSON schema, and safety constraints.
| 2. **Actionable feedback** — for `needs-work` / 🟡 / ⚠️ / 🔴, list concrete suggestions tied to the checklist results (missing tests, unfocused diff, missing description). Be constructive and specific. | ||
| 3. **Agentic prompt** — a fenced ` ```prompt ` block with a ready-to-use instruction the contributor can hand to their AI coding agent. | ||
| 1. **Encouraging opening** — acknowledge the contribution with a specific detail. | ||
| 2. **Actionable feedback** — for `needs-work` / 🟡 / ⚠️ / 🔴, list concrete suggestions (missing tests, unfocused diff, missing description). |
There was a problem hiding this comment.
The phrase "Be constructive and specific" was dropped from item 2 along with "tied to the checklist results." Both serve as quality-shaping signals for the agent — without them, feedback suggestions in the
comment field may become generic rather than grounded in the actual checklist outcomes. Re-adding just "Be specific" preserves the intent without adding tokens back.
| 2. **Actionable feedback** — for `needs-work` / 🟡 / ⚠️ / 🔴, list concrete suggestions (missing tests, unfocused diff, missing description). | |
| 2. **Actionable feedback** — for `needs-work` / 🟡 / ⚠️ / 🔴, list concrete suggestions tied to checklist results (missing tests, unfocused diff, missing description). Be specific. |
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/agents/contribution-checker.agent.md
Line: 80
Comment:
The phrase "Be constructive and specific" was dropped from item 2 along with "tied to the checklist results." Both serve as quality-shaping signals for the agent — without them, feedback suggestions in the `comment` field may become generic rather than grounded in the actual checklist outcomes. Re-adding just "Be specific" preserves the intent without adding tokens back.
```suggestion
2. **Actionable feedback** — for `needs-work` / 🟡 / ⚠️ / 🔴, list concrete suggestions tied to checklist results (missing tests, unfocused diff, missing description). Be specific.
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hey
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
Add this agentic workflows to your repoTo install this agentic workflow, run |
Caveman Optimization Run — 2026-05-31
Applies the caveman optimization principle to instruction files:
Files Optimized
.github/agents/contribution-checker.agent.mdWhat Was Changed
descriptionfield.needs-workexample — trimmed verbose intro sentence, shortened bullet text, and collapsed the multi-line prompt block into one line. The structure (greeting, bullets, fenced prompt) is fully preserved.What Was Preserved
All field names, verdict rules, checklist items, JSON schema, output format constraints, and security rules were kept intact.
Round-Robin Progress
Processed files 1–5 of 7 total files in the queue (wrapping from index 6 → 0–4).
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
localhostSee Network Configuration for more information.
Add this agentic workflows to your repo
To install this agentic workflow, run
Greptile Summary
This PR compresses the
contribution-checker.agent.mdinstruction file by removing the redundant H1 heading and opening description sentence, tightening the three comment-field rules, and condensing theneeds-workexample block. All verdict rules, checklist items, JSON schema, and output-format constraints are preserved intact.descriptionfield).lgtmomit-prompt-block rule folded into item 3.needs-workprompt block collapsed to a single line; bullet text shortened while keeping the same structure.Confidence Score: 4/5
Safe to merge — changes are limited to verbal compression of an agent instruction file with no functional logic removed.
The removal of 'Be constructive and specific' and 'tied to the checklist results' from item 2 is a minor reduction in quality-shaping guidance that could produce slightly less grounded feedback in practice, but the core evaluation flow is entirely unchanged.
.github/agents/contribution-checker.agent.md— confirm the dropped quality-guidance phrases in item 2 are acceptable.Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Start: PR Input] --> B{CONTRIBUTING.md\nexists?} B -- No --> C[Return ❓ no-guidelines] B -- Yes --> D[Step 2: Gather PR Data\nnumber, title, body, diff, files] D --> E[Step 2.5: Targeted Context\nread linked issue if any] E --> F[Step 3: Run Checklist\non-topic, process, focused,\ndeps, tests, description, diff-size] F --> G{Step 4: Verdict Rules} G -- on_topic=no OR\nprocess violation --> H[🔴 Off-Guidelines] G -- focused=no --> I[⚠️ Needs Focus] G -- new deps OR\nunclear/discussion --> J[🟡 Needs Discussion] G -- none triggered --> K[🟢 Aligned] H & I & J & K --> L[Step 5: Quality Signal] L -- 🔴 + no desc\n+ no purpose --> M[spam] L -- ⚠️/🟡 OR\nmissing tests/desc --> N[needs-work] L -- 🟢 + tests\n+ description --> O[lgtm] M & N & O --> P[Output JSON\nwith comment field] P --> Q{quality?} Q -- lgtm --> R[comment: congratulate\nno prompt block] Q -- needs-work/spam --> S[comment: opening +\nfeedback + prompt block]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "chore: caveman optimize contribution-che..." | Re-trigger Greptile