chore: artisan add trigger lagoon deploy and run lagoon commands on app instances #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bomoko
requested changes
Jan 6, 2026
| // We escape the project and branch, but we assume the command is provided as desired. | ||
| // Note: If the command contains quotes, the user should escape them or wrap the whole arg in quotes in the shell. | ||
|
|
||
| $fullCommand = sprintf('lagoon ssh -p %s -e %s -- %s', |
Contributor
There was a problem hiding this comment.
So, I suppose that we know that the lagoon cli is installed in the php container. But this does introduce a potentially unneeded requirement, given that we actually have a way of executing shell commands in the upstream library - https://github.com/amazeeio/polydock-lagoon-php-lib/blob/main/src/Ssh.php#L47
Contributor
There was a problem hiding this comment.
Futher, I'm not sure this will even simply run ...
| $bar = $this->output->createProgressBar($count); | ||
| $bar->start(); | ||
|
|
||
| foreach ($instances as $instance) { |
Contributor
There was a problem hiding this comment.
Have you considered making this optionally able to run these concurrently? Running them serially might become a problem with long running commands.
| ); | ||
|
|
||
| // Log what we are doing | ||
| // $this->line("\nExecuting on {$projectName} ({$branch})..."); |
| // Construct Lagoon CLI command | ||
| // lagoon deploy -p <project> -e <branch> | ||
|
|
||
| $fullCommand = sprintf('lagoon deploy -p %s -e %s', |
Contributor
There was a problem hiding this comment.
This should be done with the php library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.