Added Duration#toFormatted - #39
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d97dec1b17
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
EthanRBrown
added a commit
that referenced
this pull request
Feb 4, 2026
While testing #39, I stumbled on an error in the json / schema / json test. I was able to reproduce it with the `fast-check` seed and path. I can tackle fixing this, but I'm going to focus on other things for now.
EthanRBrown
force-pushed
the
duration-formatting
branch
2 times, most recently
from
February 4, 2026 18:28
50cb7e1 to
3ab8071
Compare
lazamar
requested changes
Feb 6, 2026
After Marcelo and I finally agreed upon an API, this implements that. Notes: To support this in a robust/consistent manner, the following methods were also added: - `Duration#asWeeks` - `Duration#toPartsArray` (in addition to being usefully internally, this will be useful to anyone wishing to do more custom duration formatting, providing the parts in an ordered array with associated unit labels) Note that this also changes the API of `parts` in a backwards-compatible way: when called without arguments, parts returns what it always has, but now a `largestUnits` argument can be provided which accomodates for weeks (and makes space for future expansion, e.g. years).
EthanRBrown
force-pushed
the
duration-formatting
branch
from
May 18, 2026 19:34
3ab8071 to
64cfe83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For formatting human-readable durations (e.g. "1d 2m").