Skip to content

Review VITE BASE URL for integration #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christopherpcosta merged 1 commit into from
Apr 27, 2026
Merged

Review VITE BASE URL for integration #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/ambar-task-explorer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ jobs:
platforms: linux/amd64,linux/arm64
build-args: |
GITHUB_TOKEN=${{ secrets.READ_ACCESS_TO_REPOS }}
VITE_BASE_PATH=/tasks/
cache-from: type=gha,scope=task-explorer
cache-to: type=gha,mode=max,scope=task-explorer

Expand All @@ -148,7 +149,14 @@ jobs:
tags: |
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ steps.version.outputs.value }}
# VITE_BASE_PATH is baked into the frontend bundle at build time
# (Vite emits absolute /tasks/assets/... refs and TanStack Router
# uses BASE_URL as its basepath). The published image is therefore
# locked to serving at /tasks. AmbarCLI's task-explorer module
# default basePath matches; tenants who override it will get a
# blank page — see ambar_tools registry comment.
build-args: |
GITHUB_TOKEN=${{ secrets.READ_ACCESS_TO_REPOS }}
VITE_BASE_PATH=/tasks/
cache-from: type=gha,scope=task-explorer
cache-to: type=gha,mode=max,scope=task-explorer
2 changes: 1 addition & 1 deletion task-explorer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "task-explorer",
"private": true,
"version": "0.1.1",
"version": "0.1.2",
"scripts": {
"dev:frontend": "pnpm --filter './frontend' dev -- --host 0.0.0.0",
"dev:api": "pnpm --filter './backend' dev",
Expand Down
Loading