Skip to content

fix(core): make @ambarltd/core/tracing resolve — promote facade to file-module #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christopherpcosta merged 2 commits into from
Jun 12, 2026
Merged

fix(core): make @ambarltd/core/tracing resolve — promote facade to file-module #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0dda89
fix(core): map ./tracing subpath to dist/tracing/index explicitly
christopherpcosta Jun 12, 2026
70bfef7
rework: promote tracing facade to file-module instead of exports entry
christopherpcosta Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/tracing/index.ts → core/src/tracing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
//
export { type Tracer, type Attributes, type Name, setTracer, trace, traceP, traceF, event };

import type { Future } from "../future";
import type { Future } from "./future";

// A flat bag of primitive values attached to a trace or event.
type Attributes = Record<string, string | number | boolean>;
Expand Down
2 changes: 1 addition & 1 deletion core/src/tracing/opentelemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
// OTLP trace viewer such as https://tracekit.dev/tools/trace-visualizer.
export { OpenTelemetryTracer, OtlpJsonStdoutProcessor };

import { type Tracer, type Attributes } from "./index";
import { type Tracer, type Attributes } from "../tracing";
import { Future } from "../future";
import {
context,
Expand Down
2 changes: 1 addition & 1 deletion core/src/tracing/proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// }));
export { ProxyTracer, type Config };

import { type Tracer, type Attributes } from "./index";
import { type Tracer, type Attributes } from "../tracing";
import type { Future } from "../future";
import { fileURLToPath } from "node:url";
import { dirname, sep } from "node:path";
Expand Down
2 changes: 1 addition & 1 deletion core/src/tracing/simple.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// $ docker logs event-sourcing-backend | grep "\"ph\"" | jq -s '.' >events.json
export { SimpleTracer };

import type { Tracer, Attributes } from "./index";
import type { Tracer, Attributes } from "../tracing";
import { Future } from "../future";
import { AsyncLocalStorage } from "node:async_hooks";

Expand Down
Loading