This repository was archived by the owner on Jun 19, 2020. It is now read-only.
Conversation
On Windows the temp file must be closed, otherwise mypy can't open it again. Unfortunately, we then loose the nice to read `with` sugar and obviously must call `os.remove` manually.
Contributor
Author
|
Replaces #15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mypy changed the col base. We need to normalize this column to the base flake8 expects.
Tested with mypy-0.610
E.g. before the patch
First comes the raw stdout from mypy. You can see that mypy reports
17:1but the flake8 output indicates an error at17:2This patch of course reduces the failing Travis CI. And, unfortunately, this is again on top of my previous PR, but you can cherry-pick whatever you want. And the commits are tiny.