Make aie smu code common for aie2 and aie4#1120
Make aie smu code common for aie2 and aie4#1120donwalkarsoham wants to merge 3 commits intoamd:mainfrom
Conversation
Signed-off-by: Soham Donwalkar <soham.donwalkar@amd.com>
|
Can one of the admins verify this patch? |
|
ok to test |
1 similar comment
|
ok to test |
|
retest this please |
src/driver/amdxdna/aie2_pci.c
Outdated
| struct pci_dev *pdev = to_pci_dev(xdna->ddev.dev); | ||
| void __iomem *tbl[PCI_NUM_RESOURCES] = {0}; | ||
| struct amdxdna_dev_hdl *ndev; | ||
| struct smu_config smu_conf = {}; |
There was a problem hiding this comment.
Synced with latest upstream patch as well as rebased the commit on top of other changes added to the driver.
Addressed above comments in the latest version.
xdavidz
left a comment
xdavidz
left a comment
There was a problem hiding this comment.
I am ok with this, but in the future we should not have smu.interval and smu.timeout.
The smu IP is the same between aie2 and aie4.
Signed-off-by: Soham Donwalkar <soham.donwalkar@amd.com>
Synced with latest upstream patch as well as rebased the commit on top of other changes added to the driver. |
|
retest this please |
6 participants
Problem solved by the commit
Add common smu code for both aie2 and aie4
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
N/A
How problem was solved, alternative solutions (if any) and why they were rejected
1> Removed duplicates and merged common code.
Risks (if any) associated the changes in the commit
Should be backward compatible
What has been tested and how, request additional testing if necessary
1> Driver installation successful.
2> Ran xrt_test 0 1 2 6 successfully
Documentation impact (if any)
N/A