Merge pull request #1 from amdoi7/master - #1
Open
Fengsuid wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates local configuration/data used by the HDU library seat-booking CLI, including adding .env loading support and refreshing cached room/seat metadata.
Changes:
- Load environment variables from
.envat CLI startup and addpython-dotenvas a project dependency. - Update room/floor name mappings in
utils/config.toml(including adding floor1558and renaming some labels). - Refresh
data/rooms_cache.jsonand adjust.gitignorepatterns for cache files.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/config.toml | Updates room/floor ID-to-name mappings for seat lookup/display. |
| utils/cli.py | Loads .env and tweaks CLI output / config source handling. |
| pyproject.toml | Adds python-dotenv dependency. |
| data/rooms_cache.json | Updates cached room/floor/seat metadata used for lookups. |
| .gitignore | Fixes __pycache__ ignore typo and refines cache ignore rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 1000 = "二楼东学习空间" | ||
| 1524 = "二楼西学习空间" | ||
| 1221 = "四楼学习空间" | ||
| 1221 = "四楼" |
Comment on lines
+150
to
+153
| # config_file = Path("a.txt") | ||
|
|
||
| if config_file.exists(): | ||
| config_content = config_file.read_text(encoding="utf-8") | ||
| # if config_file.exists(): | ||
| # config_content = config_file.read_text(encoding="utf-8") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1