Add more modern crypto algorithms#4
Open
andrew-ar wants to merge 3 commits into
Open
Conversation
|
This would be extremely useful to me; is there any chance of merging this (and updating lite-idp's dependency) at some point? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for more crypto algorithms. Cryptographic standards are always evolving, as new attacks are discovered over time and some older algorithms fall out of usage.
Looking at the XML Signature Syntax and Processing Version 2.0 standard and the corresponding RFC 4051 there are additional crypto algorithms which would ideally be supported.
Given that older algorithms like SHA-1 are deprecated, it makes sense to allow newer ones to be used for greater future-proofing. Since the golang crypto library has provided the required implementations for many years, we can map the identifiers onto the relevant golang crypto algorithm implementations.
I hope this is helpful, please let me know if you'd like any changes 🙂