Skip to content

Surface mkdir failures in scripts/install.sh#20

Merged
ametel01 merged 1 commit into
mainfrom
fix/9-surface-mkdir-failures-install-sh
Mar 14, 2026
Merged

Surface mkdir failures in scripts/install.sh#20
ametel01 merged 1 commit into
mainfrom
fix/9-surface-mkdir-failures-install-sh

Conversation

@ametel01
Copy link
Copy Markdown
Owner

Summary

  • install_binary now fails immediately with a clear error when mkdir -p cannot create the install directory, instead of suppressing the error with 2>/dev/null || true.

Test plan

  • Verified manually: running with ATB_INSTALL_DIR=/nonexistent/deep/path now shows the mkdir failure directly
  • Normal install path continues to work as before

Closes #9

🤖 Generated with Claude Code

The install_binary function now fails immediately with a clear error
when mkdir -p cannot create the install directory, instead of
suppressing the error with 2>/dev/null || true and falling through
to a weaker writability check.

Closes #9

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 14, 2026

Warning

Rate limit exceeded

@ametel01 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 48 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d3b10c23-e39a-457f-967f-5b606a737774

📥 Commits

Reviewing files that changed from the base of the PR and between 65c4755 and 84df442.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • scripts/install.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/9-surface-mkdir-failures-install-sh
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ametel01 ametel01 merged commit 194e07a into main Mar 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Surface mkdir failures in scripts/install.sh

1 participant