Skip to content

Preserve explicit skill-generation opt-out across maintenance commands#31

Merged
ametel01 merged 1 commit into
mainfrom
fix/25-preserve-skill-opt-out
Mar 14, 2026
Merged

Preserve explicit skill-generation opt-out across maintenance commands#31
ametel01 merged 1 commit into
mainfrom
fix/25-preserve-skill-opt-out

Conversation

@ametel01
Copy link
Copy Markdown
Owner

Summary

  • Stores a ["none"] sentinel in SkillTargets when the user cancels the target picker, distinguishing "never set" (legacy) from "explicitly opted out"
  • resolveStoredTargets returns nil for the opt-out sentinel instead of falling back to all targets
  • runToolUpdate and runUninstall skip persistVerifiedSkill when targets resolve to nil

Closes #25

Test plan

  • TestResolveStoredTargets/returns_nil_when_skill_generation_is_opted_out — opt-out sentinel returns nil
  • TestResolveStoredTargets/returns_all_targets_when_state_has_no_stored_targets — legacy empty state still falls back
  • TestResolveStoredTargets/returns_only_stored_targets — explicit opt-in honored
  • TestFinishInstallPersistsStateWhenTargetsCanceled — now also verifies the opt-out sentinel is written
  • All existing tests pass, golangci-lint clean

🤖 Generated with Claude Code

Store a sentinel value in SkillTargets when the user cancels the target
picker during install. Update and uninstall now check for this sentinel
and skip skill generation instead of falling back to all targets.

Closes #25

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 14, 2026

Warning

Rate limit exceeded

@ametel01 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 43 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 43167c0f-5b4d-49f6-b3ff-578ac0ba8cfc

📥 Commits

Reviewing files that changed from the base of the PR and between a25e8fe and a731341.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • cmd/atb/runtime.go
  • cmd/atb/runtime_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/25-preserve-skill-opt-out
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ametel01 ametel01 merged commit fab10b5 into main Mar 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve explicit skill-generation opt-out across maintenance commands

1 participant