Preserve explicit skill-generation opt-out across maintenance commands#31
Conversation
Store a sentinel value in SkillTargets when the user cancels the target picker during install. Update and uninstall now check for this sentinel and skip skill generation instead of falling back to all targets. Closes #25 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
["none"]sentinel inSkillTargetswhen the user cancels the target picker, distinguishing "never set" (legacy) from "explicitly opted out"resolveStoredTargetsreturns nil for the opt-out sentinel instead of falling back to all targetsrunToolUpdateandrunUninstallskippersistVerifiedSkillwhen targets resolve to nilCloses #25
Test plan
TestResolveStoredTargets/returns_nil_when_skill_generation_is_opted_out— opt-out sentinel returns nilTestResolveStoredTargets/returns_all_targets_when_state_has_no_stored_targets— legacy empty state still falls backTestResolveStoredTargets/returns_only_stored_targets— explicit opt-in honoredTestFinishInstallPersistsStateWhenTargetsCanceled— now also verifies the opt-out sentinel is writtengolangci-lintclean🤖 Generated with Claude Code