chore(#760): LOW tier — remove old skills, fix direction ternary (#735, #738)#775
Merged
amiable-dev merged 2 commits intomainfrom Mar 23, 2026
Merged
chore(#760): LOW tier — remove old skills, fix direction ternary (#735, #738)#775amiable-dev merged 2 commits intomainfrom
amiable-dev merged 2 commits intomainfrom
Conversation
conductor-device-setup → conductor-binding-setup (ADR-022 D9) conductor-midi-learn → conductor-learn (ADR-022 A2.3) Old directories retained for backward compat during migration, now safe to remove since the new skills are in place. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ap (#735) Consistent with DeviceDetail.svelte and DirectionBadge.svelte patterns. Easier to extend if a 4th direction value is added. 26 DeviceEditor tests pass. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes two LOW-tier cleanup items from the #760 backlog by removing deprecated agent skill directories and simplifying the DeviceEditor direction label rendering in the GUI.
Changes:
- Removed deprecated skills
conductor-device-setupandconductor-midi-learn(and their reference docs) now superseded byconductor-binding-setup/conductor-learn. - Replaced an inline direction-label ternary chain in
DeviceEditor.sveltewith aDIR_LABELSlookup map for consistent label rendering.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| skills/conductor-midi-learn/SKILL.md | Deleted deprecated Learn skill (superseded by conductor-learn). |
| skills/conductor-midi-learn/references/PATTERNS.md | Deleted deprecated pattern reference doc for the removed Learn skill. |
| skills/conductor-device-setup/SKILL.md | Deleted deprecated setup skill (superseded by conductor-binding-setup). |
| skills/conductor-device-setup/references/DEVICES.md | Deleted deprecated supported-devices reference doc for the removed setup skill. |
| conductor-gui/ui/src/lib/components/DeviceEditor.svelte | Introduced DIR_LABELS map to render direction labels without a nested ternary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LOW tier cleanup from #760 quality review backlog:
#738: Remove deprecated skill directories
skills/conductor-device-setup/(replaced byconductor-binding-setup)skills/conductor-midi-learn/(replaced byconductor-learn)#735: DeviceEditor direction label cleanup
DIR_LABELSlookup mapRemaining LOW items — intentionally deferred
Most remaining LOW items are either:
allowed-toolspattern, L1 inline vs file loadThese don't warrant fixes — they're documented in #760 as known limitations.
#760 is now substantially complete
🤖 Generated with Claude Code