Remove self-species collisions from updates#968
Closed
Maxwell-Rosen wants to merge 1 commit intomainfrom
Closed
Conversation
…control collision updates. Remove nested if statements for readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responding to #967, I'm adding an option to remove species collisions from the dfdt update and CFL calculation.
The large number of lines changed is because this function was wrapped in a giant if statement, which is a fail condition and can be refactored to the top of the file, reducing the layering and indenting.
To condense the changes, the meaningful thing that this flag does is set
Disabling the RHS still means the cross moments are computed, but
gkyl_dg_updater_lbo_gyrokinetic_advanceis not called to advance the CFL rate. We still want to callgkyl_prim_lbo_cross_calc_advancebecause this is the object that evaluates the moments used for cross-species collisions, which we need for other species.