Conversation
JunoRavin
approved these changes
Mar 10, 2026
Collaborator
|
It sounds like there should be a separate 2x and 3x updater. Putting this if statement makes me think this function should be renamed. There is also an if statement for cdim==3, so this might be preferred to go inside there. |
Collaborator
|
which regression test specifically? i've been running rt_gk_sheath_2x2v_p1 without problems |
manauref
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2x2v GK regression test are segfaulting since the merge of the write twist-shift function because if
cdim==2, thebc_sheathupdater is not allocated sogk_field_2x3x_write_twistshiftis looking for unallocated arrays.This PR just add condition for
cdim==3. We could also remove the condition and makegk_field_2x3x_write_twistshiftto be deactivated but since it is called only at the initial state I think that this would be an overkill.