[codex] Scope AI config failures to analysis endpoint - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IAiFlagAnalyzerimplementation for missing Azure OpenAI configuration.AzureOpenAI:Endpointis blank or missing instead of throwing during startup./api/flags/healthreturns the documented 503 ProblemDetails response.Why
The Phase 1 / 1.5 architecture review found that missing Azure OpenAI configuration could crash the entire API at startup. AI flag health analysis is optional and should fail at the endpoint boundary, not take down unrelated CRUD or evaluation endpoints.
Validation
dotnet test Banderas.Tests.Integration/Banderas.Tests.Integration.csproj --no-restoredotnet test Banderas.Tests/Banderas.Tests.csproj --no-restoreNotes
.gitignorechange unstaged and out of this PR.Banderas.Infrastructure/Telemetry/NullTelemetryService.cs.