Repository navigation
feat(flag): add optimistic concurrency token via xmin - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flag.Version(uint) to the Postgresxminsystem column withIsRowVersion(). EF includes it in theWHEREclause on everyUPDATE/DELETE, so conflicting writes raiseDbUpdateConcurrencyExceptioninstead of silently last-write-winning.DbUpdateConcurrencyExceptionat the repository edge into a newFlagConcurrencyException(HTTP 409), mirroring the existing23505→DuplicateFlagNameExceptionpattern. Application and APIlayers stay free of EF Core types.
Why xmin over
byte[] Versionbyte[] Version + IsRowVersion()is the canonical EF Core row-version pattern but only works on SQL Server. On Npgsql it produces abyteacolumn the database never auto-updates — the concurrency checkbecomes a silent no-op.
uint Versionlets the Npgsql provider map toxmin, which Postgres maintains on every row change for free. The generated migration emits no real DDL becausexminis a system columnalready present on every Postgres row.
Follow-ups (not in this PR)
PUT /api/flags/...requests and asserting a 409 ProblemDetails response.xminto be safe).Test plan
dotnet build Banderas.sln -p:TreatWarningsAsErrors=true— 0 warnings, 0 errorsdotnet test Banderas.sln --filter "FullyQualifiedName~FlagConcurrencyTokenTests"— passesdotnet test Banderas.slndotnet ef database updateapplies cleanly on a fresh Postgres