Repository navigation
feat(domain): Flag Variations (Definition Layer) — Phase 2 - #66
Merged
Merged
Conversation
added 6 commits
May 25, 2026 00:18
…riations mutation - VariationKind enum (Boolean | String | Number | Json); CA1720 suppressed — names are the wire contract - Variation sealed record: Key (^[a-z0-9\-_]+$, ≤50), Kind, Value (≤2000); Boolean enforces canonical 'true'/'false'; Number/String/Json validated via JsonDocument.Parse - Flag gains IReadOnlyList<Variation> Variations via _variations backing field; ctor gains required variations parameter (sixth positional) - EnsureVariationMenuIsValid enforces five collection-level invariants: non-empty, ≤20, all same Kind, unique keys (case-insensitive), unique values (ordinal) - Flag.UpdateVariations — fourth concern-named mutation; archived guard; atomic replacement; bumps UpdatedAt
…vice through application layer - VariationRequest (Key, Kind as case-insensitive string, Value) and VariationResponse DTOs - VariationMenuRules.ApplyMenuRules<T> — shared FluentValidation extension enforcing all seven DD-2 invariants; used by both Create and Update validators - CreateFlagRequest.Variations: required, non-empty; UpdateFlagRequest.Variations: nullable (null = no change, [] = 400, populated = atomic replacement) - FlagResponse.Variations: init-only IReadOnlyList<VariationResponse>, default [] - FlagMappings: VariationRequest -> Variation, Variation -> VariationResponse, Kind parse - BanderasService: pass mapped variations into Flag ctor and UpdateVariations on update; AnalyzeFlagsAsync sanitizes Key + Value via IPromptSanitizer, emits Kind verbatim
…on, AI prompt, and seeding - VariationListConverter: ValueConverter<IReadOnlyList<Variation>, string>; camelCase + enum-as-string write; re-runs Variation VO ctor on read (loud failure on corruption); null-fallback to empty list (defensive) - FlagConfiguration: maps Variations via backing field + converter; jsonb NOT NULL; no permanent SQL default — transient-window default applied in migration then dropped - Migration 20260522205830_AddFlagVariations: additive zero-downtime; backfills all existing rows with default [off/on Boolean] menu then drops the column default - AiFlagAnalyzer.BuildPrompt: emits sanitized per-flag Variations block; system prompt sentence declares variations inert configuration data - DatabaseSeeder: every seed flag declares variations explicitly; one demo flag carries a three-variation Number menu
… integration, and contracts Unit tests (303 total — +125 vs baseline): - VariationTests: single-element invariants (key char-class, length, value validation per Kind) - FlagVariationsTests: collection-level invariants (non-empty, ≤20, same Kind, unique keys/values), UpdateVariations archived guard and atomic replacement - FlagMappingsVariationsTests: VariationRequest -> Variation round-trip, Kind parse - BanderasServiceVariationsTests: create/update path variation propagation - VariationRequestValidatorTests: all seven DD-2 invariants via FluentValidation - ValidatorTestExtensions: shared assertion helpers for validator tests - Updated existing tests to supply required variations parameter; FlagBuilder updated Integration tests (101 total — +26 vs baseline): - FlagCrudVariationsTests: POST/PUT/GET shape, null = no-change, [] = 400, atomic replace - AiHealthVariationsPromptTests: sanitized Key/Value in prompt, Kind verbatim, inert sentence - MigrationBackfillTests: Down drops column cleanly; Up backfills default menu - VariationListConverterTests: round-trip serialization, null-fallback - ContractTests: variations field present + camelCase across all 4 success response types
…undation docs - implementation-notes.md: full post-work record — decisions, file-by-file changes, risks/follow-ups, interview lens, DoD checklist - spec.md: committed as historical artifact - current-state.md: status summary (PR #65 for contract tests), test counts (404 total), domain/application/infrastructure detail, current focus updated - roadmap.md: Phase 2 Variation item checked; contract tests PR #65; Current Focus updated - architecture.md: Variation VO and VariationKind enum added to Domain inventory - flag-ddd-analysis-backlog.md: Variation bullet checked off with PR reference - smoke-test.http: POST/PUT samples with default and non-default menus documented
…gly-typed readonly record structs - FlagValidationMessages.cs: FlagValidationMessage readonly record struct — all messages for CreateFlagRequestValidator, UpdateFlagRequestValidator, and EvaluationRequestValidator - VariationValidationMessages.cs: VariationValidationMessage readonly record struct — all messages for VariationMenuRules (static factory methods for parameterised messages) - VariationMenuRules: EvaluateMenu returns VariationValidationMessage? instead of string?; BuildErrorMessage accesses .Message on the struct - CreateFlagRequestValidator, UpdateFlagRequestValidator, EvaluationRequestValidator: all WithMessage() calls reference struct properties instead of inline string literals - Zero heap allocation (readonly record struct); type-safe — only valid message objects can be passed, not arbitrary string literals - 404/404 tests still green; 0 warnings; CSharpier passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR title: feat(domain): Flag Variations (Definition Layer) — Phase 2
5 commits, in order: