Plotting options

[amorison]

This is a PR created from #3 to keep the scope of the latter small.

I think the changes proposed are good in term of features, i.e. being able to plot only the temperature field, or have various levels of "verbosity" in annotations.

However, even before this PR, I was already not happy with the state of the plotting module. Its functions have exploded in complexity and numbers of arguments since their creations as our plotting needs evolved. I think this complexity is a symptom that the current code is not designed properly. These functions should be decomposed in smaller objects that represent the "subplots" we're interested in and that can be more easily combined rather than adding even more switches. I've had success using https://github.com/amorison/lazympl in other projects to make composable plots and annotations, I'll give this a go.

I'm keeping this PR open for now as a reminder that we want to implement these functionalities, even if the actual design might end up being different.

[labrosse]

I agree with all that and this PR resulted from some current need I have and I think these options should exist. Another feature I need and will implement in my version is also in line with a more modular view of the plotting functions: instead of saving the figures to a file, it would be useful to put them in an axe, as part of a larger complex figure. The way I will implement that will require to have again an additional argument, axe, which if not none, will put the figure in that axe instead of a pdf file. I am sure there is a better option to do it, though.

…

-- Stephane Labrosse | +33 4 72 72 85 15 Dept/Labo. Géologie Lyon, ENS de Lyon | https://labrosse.github.io/ 46 allee d'Italie, 69364 Lyon cedex 07, France

Le 8 janv. 2025 à 03:13, Adrien Morison ***@***.***> a écrit : This is a PR created from #3 <#3> to keep the scope of the latter small. I think the changes proposed are good in term of features, i.e. being able to plot only the temperature field, or have various levels of "verbosity" in annotations. However, even before this PR, I was already not happy with the state of the plotting module. Its functions have exploded in complexity and numbers of arguments since their creations as our plotting needs evolved. I think this complexity is a symptom that the current code is not designed properly. These functions should be decomposed in smaller objects that represent the "subplots" we're interested in and that can be more easily combined rather than adding even more switches. I've had success using https://github.com/amorison/lazympl in other projects to make composable plots and annotations, I'll give this a go. I'm keeping this PR open for now as a reminder that we want to implement these functionalities, even if the actual design might end up being different. You can view, comment on, or merge this pull request online at: #4 Commit Summary 8c344df <8c344df> adds the realbare option to plot_fastest_mode_cart e2e2d7d <e2e2d7d> adds the option of plotting of only T or stream File Changes (1 file <https://github.com/amorison/stablinrb/pull/4/files>) M stablinrb/plotting.py <https://github.com/amorison/stablinrb/pull/4/files#diff-97b04a5a343305cc5a6edd1b079b88cc7b9f34fedf0c2f18662550c2e08448aa> (44) Patch Links: https://github.com/amorison/stablinrb/pull/4.patch https://github.com/amorison/stablinrb/pull/4.diff — Reply to this email directly, view it on GitHub <#4>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACQ223VBRRBDTKFR2MQKUYT2JSCVJAVCNFSM6AAAAABUY47KIGVHI2DSMVQWIX3LMV43ASLTON2WKOZSG43TIMBYGA4DQNI>. You are receiving this because you are subscribed to this thread.