Conversation
liuxincuit
added a commit
to liuxincuit/learn
that referenced
this pull request
Sep 15, 2026
render_svg 的两级回退扩成三级：rsvg-convert → magick → headless Chrome/Edge 截图。本机前两级都不存在（MISSING），所以这一级是 SVG 那一半 唯一的活路；浏览器取 _common.ts 已有的 findChrome() / findEdge()，零新依赖。 - viewport 必须等于 SVG 的声明尺寸：独立 SVG 文档按自身尺寸画在 viewport 左上，窗口更大只留白、不缩放。intrinsicSize() 解析 width/height（仅认裸 数字或 px）→ viewBox 第 3/4 个数 → 800x600，夹到 [32, 4000]。 - --user-data-dir 落在 sessionId 键的 staging 目录里，并行 maker 不共享 profile；实测两个 headless 实例并发互不干扰。 - 失败信息改为汇总三级尝试。已知取舍：畸形 SVG 时 Edge 退出码仍是 0（PNG 里是 Chromium 的红色解析错误页），所以"返回错误文本"只剩文件未生成/超时 触发。 验证：testbed 里派 svg-maker 画数轴，write → 预览 render → 发布 render 全 链路通过，产出 viz-number-line-minus2-0-1p5-1789470102966.png（1600x380， 实看图：-2 / 0 / 1.5 三点间距正确、无裁切）；staging 目录里的 browser-profile/ 证明走的是浏览器而非前两级。intrinsicSize() 单测 9 组用例 全过（stroke-width 不误匹配、100% / 12cm 回退 viewBox）。 - skills/visualize/SKILL.md:79：渲染后端说明补上浏览器回退。 - ADAPTATION.md：差异 amosblomqvist#6 改已解决；新增 2.6 节记回退链实测事实；第 7 节加 SVG 端到端验证行；进度 amosblomqvist#6 结案。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a grammar issue in
agents/mermaid-maker.md(line 15).Problem
Subject-verb agreement: the compound subject lists three items but takes the singular verb "is". A compound subject joined by commas requires a plural verb.
The problematic text:
Fix
Replaced with:
Type of Change
Checklist