Skip to content

fix: Generate presigned URLs on-demand for profile images#12

Merged
amoscicki merged 1 commit into
mainfrom
AM03/bugfix/34-profile-image-presigned-urls
Dec 28, 2025
Merged

fix: Generate presigned URLs on-demand for profile images#12
amoscicki merged 1 commit into
mainfrom
AM03/bugfix/34-profile-image-presigned-urls

Conversation

@amoscicki
Copy link
Copy Markdown
Owner

  • Generate fresh presigned URLs in data-access layer instead of storing
  • Profile images now persist indefinitely (no 1-hour expiry)
  • Upload only stores imageId (R2 key), not the presigned URL

@amoscicki amoscicki force-pushed the AM03/bugfix/34-profile-image-presigned-urls branch from 4435371 to fd30fdc Compare December 25, 2025 03:27
@amoscicki amoscicki force-pushed the AM02a/fix/dev-mode-and-playwright-tests branch from b0ca7e9 to c9d01ec Compare December 25, 2025 03:27
@amoscicki amoscicki force-pushed the AM03/bugfix/34-profile-image-presigned-urls branch from fd30fdc to f244b7a Compare December 25, 2025 12:03
@amoscicki amoscicki force-pushed the AM02a/fix/dev-mode-and-playwright-tests branch 2 times, most recently from 6daf4be to 742011c Compare December 25, 2025 12:12
@amoscicki amoscicki force-pushed the AM03/bugfix/34-profile-image-presigned-urls branch from f244b7a to cd1a684 Compare December 25, 2025 12:12
@amoscicki amoscicki force-pushed the AM02a/fix/dev-mode-and-playwright-tests branch from 742011c to 39c1acf Compare December 25, 2025 12:23
@amoscicki amoscicki force-pushed the AM03/bugfix/34-profile-image-presigned-urls branch from cd1a684 to 0cec8f9 Compare December 25, 2025 12:23
@amoscicki amoscicki force-pushed the AM02a/fix/dev-mode-and-playwright-tests branch from 39c1acf to c21664c Compare December 25, 2025 13:07
@amoscicki amoscicki force-pushed the AM03/bugfix/34-profile-image-presigned-urls branch from 0cec8f9 to 6e6f5ef Compare December 25, 2025 13:08
@amoscicki amoscicki changed the base branch from AM02a/fix/dev-mode-and-playwright-tests to graphite-base/12 December 26, 2025 00:54
@amoscicki amoscicki force-pushed the AM03/bugfix/34-profile-image-presigned-urls branch from 6e6f5ef to a5fc4a7 Compare December 27, 2025 23:42
@amoscicki amoscicki changed the base branch from graphite-base/12 to AM02a/fix/dev-mode-and-playwright-tests December 27, 2025 23:42
@amoscicki amoscicki force-pushed the AM02a/fix/dev-mode-and-playwright-tests branch from 41f2acc to af2f1e0 Compare December 28, 2025 05:34
@amoscicki amoscicki force-pushed the AM03/bugfix/34-profile-image-presigned-urls branch from a5fc4a7 to eb271f0 Compare December 28, 2025 05:34
@amoscicki amoscicki force-pushed the AM02a/fix/dev-mode-and-playwright-tests branch from af2f1e0 to d75568e Compare December 28, 2025 05:58
@amoscicki amoscicki force-pushed the AM03/bugfix/34-profile-image-presigned-urls branch from eb271f0 to 4de4dff Compare December 28, 2025 05:58
@amoscicki amoscicki force-pushed the AM02a/fix/dev-mode-and-playwright-tests branch from d75568e to e9d6e1c Compare December 28, 2025 06:33
@amoscicki amoscicki force-pushed the AM03/bugfix/34-profile-image-presigned-urls branch from 4de4dff to ca098d5 Compare December 28, 2025 06:33
@amoscicki amoscicki force-pushed the AM03/bugfix/34-profile-image-presigned-urls branch 4 times, most recently from 573dd81 to c260aa9 Compare December 28, 2025 14:54
@amoscicki amoscicki changed the base branch from AM02a/fix/dev-mode-and-playwright-tests to graphite-base/12 December 28, 2025 19:38
@amoscicki amoscicki force-pushed the AM03/bugfix/34-profile-image-presigned-urls branch from c260aa9 to 0268f21 Compare December 28, 2025 19:38
@amoscicki amoscicki changed the base branch from graphite-base/12 to main December 28, 2025 19:39
- Generate fresh presigned URLs in data-access layer instead of storing
- Profile images now persist indefinitely (no 1-hour expiry)
- Upload only stores imageId (R2 key), not the presigned URL
@amoscicki amoscicki force-pushed the AM03/bugfix/34-profile-image-presigned-urls branch from 0268f21 to 0075d5b Compare December 28, 2025 19:39
@amoscicki amoscicki marked this pull request as ready for review December 28, 2025 20:52
@amoscicki amoscicki merged commit 4ea3bf0 into main Dec 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant