fix: surface MCP proxy HTTP errors - #86
Open
RaphaelKhalid wants to merge 1 commit into
Open
RaphaelKhalid wants to merge 1 commit into
RaphaelKhalid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send-requesttool through the existingcallAmpersandProxyhelper.Motivation
The current MCP handler parses any JSON proxy response and returns
API call successful, even when the proxy returns a non-2xx status. This makes an upstream failure look like a successful tool invocation to an MCP client or agent. The shared helper already checksresponse.okand throws with the status, so this change removes the duplicated request path and aligns MCP behavior with the AI SDK and Mastra adapters.Related: #40
Testing
git diff --checkpasses.Unable to follow symbol for "InferPublicSchema"under the workspace's current dependency resolution. Bun is not available in the environment, so the Bun integration suite could not be run locally.