Skip to content

[ENG-4255] feat(notifications): write.async.done sends error string instead of errors array #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlimatampersand wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −26
Open

[ENG-4255] feat(notifications): write.async.done sends error string instead of errors array #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 8 additions & 20 deletions notifications/generated/notifications.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,16 +904,10 @@
"rec-2"
]
},
"errors": {
"type": "array",
"description": "Error messages for records that failed during the asynchronous write operation.",
"items": {
"type": "string"
},
"example": [
"field validation failed",
"duplicate record"
]
"error": {
"type": "string",
"description": "The error that occurred during the asynchronous write operation. When multiple records fail, their error messages are joined into a single string.",
"example": "field validation failed; duplicate record"
}
}
}
Expand Down Expand Up @@ -2634,16 +2628,10 @@
"rec-2"
]
},
"errors": {
"type": "array",
"description": "Error messages for records that failed during the asynchronous write operation.",
"items": {
"type": "string"
},
"example": [
"field validation failed",
"duplicate record"
]
"error": {
"type": "string",
"description": "The error that occurred during the asynchronous write operation. When multiple records fail, their error messages are joined into a single string.",
"example": "field validation failed; duplicate record"
}
}
}
Expand Down
12 changes: 6 additions & 6 deletions notifications/notifications.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,12 +263,12 @@ components:
items:
type: string
example: ["rec-1", "rec-2"]
errors:
type: array
description: Error messages for records that failed during the asynchronous write operation.
items:
type: string
example: ["field validation failed", "duplicate record"]
error:
type: string
description: >-
The error that occurred during the asynchronous write operation. When multiple
records fail, their error messages are joined into a single string.
example: "field validation failed; duplicate record"

# Subscribe create error event data
SubscribeCreateErrorData:
Expand Down
Loading