chore: use lockfiles for NPM dependencies#42
Merged
Conversation
daniel-graham-amplitude
temporarily deployed
to
Unit Test
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces lockfile-based Node dependency management for the release workflow to make semantic-release execution deterministic in this Go repository.
Changes:
- Add a root
package.json/package-lock.jsonto lock semantic-release tooling dependencies. - Update the GitHub Actions release workflow to run
npm ciand execute semantic-release vianpm exec(dry-run and real release). - Ignore
node_modules/at the repo root.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
package.json |
Adds Node tooling dependencies intended for semantic-release execution. |
package-lock.json |
Locks resolved dependency graph for deterministic installs in CI. |
.gitignore |
Ignores node_modules/ to avoid committing installs. |
.github/workflows/release.yml |
Switches from npx -p ... to npm ci + npm exec semantic-release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+9
| "lodash": "latest", | ||
| "semantic-release": "latest", | ||
| "@semantic-release/changelog": "latest", | ||
| "@semantic-release/git": "latest", | ||
| "@google/semantic-release-replace-plugin": "latest", | ||
| "@semantic-release/exec": "latest" |
Comment on lines
+2
to
+10
| "private": true, | ||
| "dependencies": { | ||
| "lodash": "latest", | ||
| "semantic-release": "latest", | ||
| "@semantic-release/changelog": "latest", | ||
| "@semantic-release/git": "latest", | ||
| "@google/semantic-release-replace-plugin": "latest", | ||
| "@semantic-release/exec": "latest" | ||
| } |
| { | ||
| "private": true, | ||
| "dependencies": { | ||
| "lodash": "latest", |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the equivalent of amplitude/Amplitude-Swift#350 in this repository.
Changes
npx -p ...installs to lockfile-based commandsnpm cibefore semantic-release in dry-run and release stepsnpm execpackage.json+package-lock.jsonfor deterministic dependency resolutionnode_modules/in.gitignorewhere needed