Skip to content

CMake: raise minimum version#395

Open
gastmaier wants to merge 9 commits into
libiio-v1from
libiio-v1-cmake-min
Open

CMake: raise minimum version#395
gastmaier wants to merge 9 commits into
libiio-v1from
libiio-v1-cmake-min

Conversation

@gastmaier

Copy link
Copy Markdown

Increase CMake minimum required version to 3.10 to avoid warnings on modern CMake about pre-3.10 legacy behavior, and support to CMake 4.

Increase CMake minimum required version to 3.10 to avoid warnings on
modern CMake about pre-3.10 legacy behavior, and support to CMake 4.

Signed-off-by: Jorge Marques <jorge.marques@analog.com>
Signed-off-by: Jorge Marques <jorge.marques@analog.com>
Remove cp37/cp38 from CIBW_BUILD (unsupported in cibuildwheel 4.x)
Add cp313 for Python 3.13 support
Fix CIBW_DEBUG_KEEP_CONTAINER YAML syntax

Signed-off-by: Jorge Marques <jorge.marques@analog.com>
@gastmaier
gastmaier force-pushed the libiio-v1-cmake-min branch from fb7a5fc to b3a5702 Compare June 23, 2026 07:54
@gastmaier
gastmaier requested a review from Adrian-Stanea June 23, 2026 07:55
@gastmaier

Copy link
Copy Markdown
Author

why 22 and not ubuntu 24? or even 26?

Note: glog is achieved and recommends to migrate to
https://github.com/ng-log/ng-log

Signed-off-by: Jorge Marques <jorge.marques@analog.com>
@gastmaier

gastmaier commented Jun 24, 2026

Copy link
Copy Markdown
Author

@NicuS03 for context, this is to unblocking analogdevicesinc/br2-external#19
https://github.com/analogdevicesinc/br2-external/actions/runs/28109265065/job/83231887099?pr=19

i added prs around, for libiio is already merged for both v0 and v1

@NicuS03

NicuS03 commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

@gastmaier I fixed the Pipelines and the version for Libiio (to be 1.0) it should work fine.
Can you verify if this unblock your build ?

@gastmaier gastmaier left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!
For the br2-external I previously overwrote (-DCMAKE_MIN...) to 3.10 to unblock, I will now revert the commit that added the workaround

@NicuS03

NicuS03 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

I can approve this, but it's a bit strange to approve something that I edited 😄, should we find someone else to review this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants