Overwrite method if request for _method is present#63
Open
petemcfarlane wants to merge 4 commits intoanandkunal:masterfrom
Open
Overwrite method if request for _method is present#63petemcfarlane wants to merge 4 commits intoanandkunal:masterfrom
petemcfarlane wants to merge 4 commits intoanandkunal:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really like this simple router, I think it would be a touch more flexible if you were able to overwrite the request method with a simple hidden input (a similar implementation to RoR). This would mean that users don't have to use XMLHTTPRequests to do PUT or DELETE requests. It's only an extra IF check, so hopefully doesn't 'bloat' the software too much IMO, but what do I know!