Remove unused internal package#13
Open
prasanna-anchorage wants to merge 1 commit into
Open
Conversation
internal/constants.go was a stale duplicate of aws_root.go's root certificate PEM and fingerprint, left over from before the "Move code from internal/ to root package" refactor. Nothing imports github.com/anchorageoss/awsnitroverifier/internal, and no test files exist under internal/ despite comments in fixtures_test.go referring to "internal package tests" and a test "moved to internal package" - neither of which exist. Removed the package and the stale comments.
There was a problem hiding this comment.
Pull request overview
This PR removes a now-unused internal package artifact and cleans up outdated test comments left over from a prior refactor, reducing dead code and keeping test documentation accurate.
Changes:
- Deleted
internal/constants.go, which duplicated the embedded AWS Nitro root certificate PEM and fingerprint already present inaws_root.go. - Updated
fixtures_test.gocomments to remove references to non-existent “internal package tests” and a test purportedly moved to the internal package.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/constants.go | Removes a stale, duplicated internal constants file that is no longer referenced. |
| fixtures_test.go | Removes outdated comments referencing internal-package tests that no longer exist. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
prasanna-anchorage
enabled auto-merge
July 15, 2026 21:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/constants.gowas a stale duplicate ofaws_root.go's root certificate PEM and fingerprint, left over from before the "Move code from internal/ to root package" refactor. Nothing importsgithub.com/anchorageoss/awsnitroverifier/internal.fixtures_test.goreferring to "internal package tests" and a test "moved to internal package" — neither the internal test file nor that test exists.Test plan
go build ./...go vet ./...go test ./...— 122 passed