Fix issue when fromat string starts with [$-F800] and [$-F400]#42
Open
GradlonGwen wants to merge 1 commit intoandersnm:masterfrom
Open
Fix issue when fromat string starts with [$-F800] and [$-F400]#42GradlonGwen wants to merge 1 commit intoandersnm:masterfrom
GradlonGwen wants to merge 1 commit intoandersnm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug described in issue #41 where the formatted date was incorrect when the format started with "[$-F800]".
Even if not really documented (or very hard to find), locale id F800 seems to refer to the system long date.
This PR adds code to parse totally the locale id, and use it in the parser for date and time.
When parsing the date, if the locale id is F800, then the culture LongDatePattern is used instead of the tokens found with the tokeniser.
When parsing the date, the tokens are replaced with tokens generated from the culture LongTimePattern.