-
Notifications
You must be signed in to change notification settings - Fork 6
TOP - Restringir volver a auditoria si la solicitud tiene turno asignado #3254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
934933b to
3459b13
Compare
3459b13 to
15406ee
Compare
15406ee to
16be5c8
Compare
| import { Component, ElementRef, HostBinding, Input, OnInit, ViewChild } from '@angular/core'; | ||
| import { Router } from '@angular/router'; | ||
| import { catchError, concatWith, map, switchMap } from 'rxjs'; | ||
| import { catchError, concatWith, map, switchMap, EMPTY, from, filter, NEVER } from 'rxjs'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
La variable empty no se está utilizando.
El resto anda perfecto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gracias compa, queda subido el cambio.
16be5c8 to
784eedc
Compare
| this.servicioPrestacion.getById(this.prestacionSeleccionada._id) | ||
| .pipe( | ||
| switchMap(prestacion => { | ||
| const tieneTurnoInvalido = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me hace ruido el nombre, el turno se dió correctamente. Lo dejaría como "tieneTurno"
negro89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No se si hubo un cambio de rumbo en la tarea a ultimo momento pero pedía que el control estuviera del lado de la api. A pesar de esto me parece que está bien resuelto y la solución es válida.
Funciona de 10 pero dejo la duda para consultar mañana 👌🏼
784eedc to
3c4bd8a
Compare
|
aprobado por chayanne 👍🏼 |

Requerimiento
https://proyectos.andes.gob.ar/browse/TOP-199
Funcionalidad desarrollada
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
Requiere actualizaciones en la API
Requiere actualizaciones en andes-test-integracion