Add "-f Makefile" to initial "make" (no args). Set PERL env var in "make test" and "make"#100
Open
rocky wants to merge 2 commits intoandk:masterfrom
rocky:perl-env
Open
Add "-f Makefile" to initial "make" (no args). Set PERL env var in "make test" and "make"#100rocky wants to merge 2 commits intoandk:masterfrom rocky:perl-env
rocky wants to merge 2 commits intoandk:masterfrom
rocky:perl-env
Conversation
added 2 commits
July 4, 2016 08:36
ExtUtils::MakeMaker writes a file called Makefile. Explicitly use that since GNU make can default to another name, e.g. GNUMakefile. Notes: * -f is in the POSIX spec for make. * This doesn't happen if a custom make command is used, or if Module::Build's "Build" script is run Also
Owner
|
The request is missing a motivation section that explains what this pull request is trying to achieve which cannot be achieved otherwise. And it seems to violate the DRY principle, so it would help a lot if it could explain why such a violation would seem justified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried also adding the same "-f Makefile" to "make install" but a test fails:
See also discussion in cpantesters.