support gap bwtween line number and code and support 100% width#25
Open
Yiklek wants to merge 1 commit into
Open
support gap bwtween line number and code and support 100% width#25Yiklek wants to merge 1 commit into
Yiklek wants to merge 1 commit into
Conversation
Owner
|
I'm glad Lovelace is useful for you! The fix looks good on a first glance. I'll have to think through it a bit more though :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Andreas, I would like to extend my heartfelt thanks to the Lovelace package, which has been instrumental in completing my master thesis.
I noticed a small issue that It does not make full use of 100% page width. For example, when I use
#h(1fr), it still exists a gap with the edge of the page.I find it is affected by the parameter
indentation. Whenindentationis0em, there is no gap, but the code indents become weird.When
indentationis a non-zero value, the algorithm width is affected.2em:

5em:

I have fixed this issue and added a parameter
code-offsetto specify the gap between the line numbers and the code. The width is not affected by the parameterindentationand that the code is indented correctly.indentationis set to2em:code-offsetis set to2em:I'm a typst beginner, please feel free to give me advice.