Repository navigation
Redact home directories and secrets from discovery output; close Phase 2 - #13
Merged
Merged
Conversation
Manifest package and dependency names are untrusted text. The inventory now replaces home-directory prefixes with `~` and known secret shapes with `[redacted]` before they reach the graph, store, API or CLI output. The archwise.graph validator rejects labels that still contain a home directory (`home-path`), and `--json` no longer prints the absolute workspace root. Closes Phase 2: the roadmap records the exit-gate evidence, and the user guide gains a store-failure section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: André Oliveira <coliveira.andre@gmail.com>
Review findings on the redaction change: - Secrets are removed before home paths and redaction repeats until stable, so `[redacted]/Users/x` can no longer appear. - Secret redaction removes the whole token: a private-key block through its end marker and a JWT including its signature. - Generic detection is limited to `/Users/<name>` (case-sensitive) and `X:\Users\<name>`, so route labels such as `GET /users/:id` and `/home/feed` stay valid. The CLI passes the running user's real home directory for exact redaction instead. The graph-contracts spec records the `home-path` amendment, and the security docs state what is and is not redacted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: André Oliveira <coliveira.andre@gmail.com>
CodeQL js/polynomial-redos flagged the anchored trailing-separator regex. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: André Oliveira <coliveira.andre@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/Users/<name>andX:\Users\<name>shapes), repeating until stable.archwise.graphvalidator gainshome-pathfor generic home shapes in labels. Route labels such as/home/feedandGET /users/:idstay valid. The graph-contracts spec records the amendment.--jsonno longer prints the absolute workspace root. Its output now comes from an explicit allowlist of fields.Review
A fresh independent review found two Important issues, both fixed with failing tests first:
[redacted]/Users/x.The fix pass also covers partial secret redaction, which left a private-key body and a JWT signature in the output.
Deferred minors, recorded here:
Test plan
pnpm check: 400 Vitest tests and 18 integration tests pass.--jsonand--graphprint neither the root, the real home directory nor a secret.AKIA…/Users/alex/appgives[redacted]~/app.🤖 Generated with Claude Code