Repository navigation
feat: fixed docker - #61
Conversation
|
|
||
| ```bash | ||
| docker build -t postal:dev .. | ||
| docker build -t postal:dev -f docker/Dockerfile .. |
There was a problem hiding this comment.
The command mixes two working directories. From the repository root, docker/Dockerfile exists, but context .. makes COPY pyproject.toml README.md LICENSE /stub/ look outside the repository. From docker/, the context is right, but docker/Dockerfile does not exist. Use docker build -t postal:dev -f docker/Dockerfile . from the repository root.
| docker build -t postal:dev -f docker/Dockerfile .. | |
| docker build -t postal:dev -f docker/Dockerfile . |
Prompt To Fix With AI
This is a comment left during a code review.
Path: docker/README.md
Line: 33
Comment:
**Docker build paths conflict**
The command mixes two working directories. From the repository root, `docker/Dockerfile` exists, but context `..` makes `COPY pyproject.toml README.md LICENSE /stub/` look outside the repository. From `docker/`, the context is right, but `docker/Dockerfile` does not exist. Use `docker build -t postal:dev -f docker/Dockerfile .` from the repository root.
```suggestion
docker build -t postal:dev -f docker/Dockerfile .
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.| env: | ||
| TIKTOKEN_CACHE_DIR: ${{ runner.temp }}/tiktoken |
There was a problem hiding this comment.
TIKTOKEN_CACHE_DIR now applies only to the test step. The earlier “Cache tokenizer data” step fills the default cache, while the tests use a separate directory and download the same data again. Give both steps the same value, preferably through a job-level env, so the tests reuse the downloaded data.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/tests.yml
Line: 36-37
Comment:
**Tests miss the warmed cache**
`TIKTOKEN_CACHE_DIR` now applies only to the test step. The earlier “Cache tokenizer data” step fills the default cache, while the tests use a separate directory and download the same data again. Give both steps the same value, preferably through a job-level `env`, so the tests reuse the downloaded data.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| def run_repl(self, isatty: bool): | ||
| with patch("ui.repl.app.sys.stdin") as stdin, patch("ui.repl.app.shutil.which") as which: | ||
| stdin.isatty.return_value = isatty | ||
| which.return_value = "/usr/bin/node" | ||
| with patch("ui.repl.app.asyncio.create_subprocess_exec") as spawn: | ||
| with self.assertRaises(RuntimeError) as raised: | ||
| asyncio.run(Repl(Config()).run()) |
There was a problem hiding this comment.
Tests inherit the wrong interface
If a developer has the documented POSTAL_UI=textual setting, Repl.run() starts PostalApp before reaching the terminal check. These tests then exercise the wrong interface and can fail or wait for input. Clear or override POSTAL_UI in run_repl so both tests always select the TypeScript interface.
Prompt To Fix With AI
This is a comment left during a code review.
Path: tests/test_repl.py
Line: 10-16
Comment:
**Tests inherit the wrong interface**
If a developer has the documented `POSTAL_UI=textual` setting, `Repl.run()` starts `PostalApp` before reaching the terminal check. These tests then exercise the wrong interface and can fail or wait for input. Clear or override `POSTAL_UI` in `run_repl` so both tests always select the TypeScript interface.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
The PR appears safe to merge, with non-blocking fixes needed in the Docker instructions, tokenizer cache settings, and test setup.
Findings
Fix with agent prompt
Summary
The PR adds an early error when the interactive interface has no terminal, updates Docker examples, checks release metadata, and changes the project model.
Reviews (1) · Last reviewed commit: "feat: fixed docker" · Reviewed by Greptile