Skip to content

UI/tui - #62

Merged
andrefetch merged 15 commits into
mainfrom
ui/tui
Nov 17, 2026
Merged

andrefetch merged 15 commits into
mainfrom
ui/tui

Conversation

@andrefetch

@andrefetch andrefetch commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge, with a non-blocking performance concern for large live child logs.

Findings

  1. P2 Large logs slow the terminal ▶
Fix with agent prompt
### Issue 1
ui/terminal/src/agents.ts:38
Removing the output limit makes live child-tool output grow without a bound. A child running a noisy `bash` command sends every output chunk to `updateAgent`, which now retains the whole stream. Even collapsed tools clean and split that entire string on each update just to show two preview lines. Long build or test logs can therefore increase memory use and make the terminal sluggish.

Keep a bounded live preview, then preserve the completed result separately. Disclose any omitted live text.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR refreshes the terminal interface and removes the Textual fallback.

  • Tool calls show live previews and compact results, with details ready to open.
  • Delegated agents and their tool calls appear in the conversation.
  • Thinking traces animate and fold as the conversation changes.
  • The home screen gets a taller cloud logo and animated snowfall.
  • The TypeScript terminal becomes Postal’s only interactive interface.
  • The sample workspace starts with Ernie 5.5 Flash Preview.
  • GitHub’s language view skips generated JavaScript.

Reviews (8) · Last reviewed commit: "Merge branch 'ui/tui' of https://github...." · Reviewed by Greptile

Comment thread ui/terminal/src/App.tsx Resolved
Comment thread ui/terminal/src/LatticeLoader.tsx Resolved
@greptile-apps

greptile-apps Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Want your agent to iterate on Greptile's feedback? Try greploops.

Comment thread ui/terminal/src/ToolRow.tsx Resolved
Comment thread ui/terminal/src/components.tsx Resolved
Comment thread ui/terminal/src/components.tsx Resolved
Comment thread ui/terminal/src/agents.ts Resolved
Comment thread ui/terminal/src/App.tsx Resolved
Comment thread ui/terminal/src/agents.ts
tool.callId !== data.call_id ? tool : {...tool,
status: type === 'tool_progress' ? 'running' : data.success ? 'completed' : 'failed',
...(type === 'tool_call_complete' ? {finishedAt: Date.now(), metadata: data.metadata ?? {}, truncated: data.truncated, error: data.error, exitCode: typeof data.exit_code === 'number' ? data.exit_code : undefined, diff: data.diff} : {}),
output: type === 'tool_progress' ? tool.output + (data.content ?? '') : (data.output ?? tool.output),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Large logs slow the terminal

Removing the output limit makes live child-tool output grow without a bound. A child running a noisy bash command sends every output chunk to updateAgent, which now retains the whole stream. Even collapsed tools clean and split that entire string on each update just to show two preview lines. Long build or test logs can therefore increase memory use and make the terminal sluggish.

Keep a bounded live preview, then preserve the completed result separately. Disclose any omitted live text.

Prompt To Fix With AI
This is a comment left during a code review.
Path: ui/terminal/src/agents.ts
Line: 38

Comment:
**Large logs slow the terminal**

Removing the output limit makes live child-tool output grow without a bound. A child running a noisy `bash` command sends every output chunk to `updateAgent`, which now retains the whole stream. Even collapsed tools clean and split that entire string on each update just to show two preview lines. Long build or test logs can therefore increase memory use and make the terminal sluggish.

Keep a bounded live preview, then preserve the completed result separately. Disclose any omitted live text.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

@andrefetch
andrefetch merged commit ae32c87 into main Nov 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant