Repository navigation
UI/tui - #62
Merged
Merged
UI/tui#62
Conversation
Contributor
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
| tool.callId !== data.call_id ? tool : {...tool, | ||
| status: type === 'tool_progress' ? 'running' : data.success ? 'completed' : 'failed', | ||
| ...(type === 'tool_call_complete' ? {finishedAt: Date.now(), metadata: data.metadata ?? {}, truncated: data.truncated, error: data.error, exitCode: typeof data.exit_code === 'number' ? data.exit_code : undefined, diff: data.diff} : {}), | ||
| output: type === 'tool_progress' ? tool.output + (data.content ?? '') : (data.output ?? tool.output), |
Contributor
There was a problem hiding this comment.
Removing the output limit makes live child-tool output grow without a bound. A child running a noisy bash command sends every output chunk to updateAgent, which now retains the whole stream. Even collapsed tools clean and split that entire string on each update just to show two preview lines. Long build or test logs can therefore increase memory use and make the terminal sluggish.
Keep a bounded live preview, then preserve the completed result separately. Disclose any omitted live text.
Prompt To Fix With AI
This is a comment left during a code review.
Path: ui/terminal/src/agents.ts
Line: 38
Comment:
**Large logs slow the terminal**
Removing the output limit makes live child-tool output grow without a bound. A child running a noisy `bash` command sends every output chunk to `updateAgent`, which now retains the whole stream. Even collapsed tools clean and split that entire string on each update just to show two preview lines. Long build or test logs can therefore increase memory use and make the terminal sluggish.
Keep a bounded live preview, then preserve the completed result separately. Disclose any omitted live text.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Confidence Score: 5/5
The PR appears safe to merge, with a non-blocking performance concern for large live child logs.Findings
Fix with agent prompt
Summary
The PR refreshes the terminal interface and removes the Textual fallback.
Reviews (8) · Last reviewed commit: "Merge branch 'ui/tui' of https://github...." · Reviewed by Greptile