[WIP] drop julia < 0.5 and prepare for 0.6#21
Open
CarloLucibello wants to merge 7 commits intoandrewcooke:masterfrom
Open
[WIP] drop julia < 0.5 and prepare for 0.6#21CarloLucibello wants to merge 7 commits intoandrewcooke:masterfrom
CarloLucibello wants to merge 7 commits intoandrewcooke:masterfrom
Conversation
3 tasks
CarloLucibello
changed the title
Collaborator
Author
|
@andrewcooke @sbromberger can someone continue from here or give me a hand? On julia 0.6 there are still a lot of tests not passing, and some passing but giving weird results. Also due to the new Channel sintax this is not working on 0.5 right now and I'm not sure 0.5 compatibility can be kept. This is a minor problem, maybe it is just better to drop 0.5 to have the most maintanable thing we can have |
Contributor
|
Yeah, we're seeing similar issues in LG right now. Our solution is to move 0.6 compatibility into its own branch that will not be backwards-compatible with 0.5. |
Collaborator
Author
|
@andrewcooke if you find some spare time please continue the update work from here. There are a few issues left that I couldn't manage to solve, shouldn't take much though. Bye |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trying to address #23