Skip to content

Add bazel#107

Merged
andrewpollack merged 3 commits intomainfrom
add-bazel
Jul 28, 2025
Merged

Add bazel#107
andrewpollack merged 3 commits intomainfrom
add-bazel

Conversation

@andrewpollack
Copy link
Owner

No description provided.

@andrewpollack andrewpollack requested a review from Copilot July 28, 2025 19:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the entire Go infrastructure from Docker-based builds to Bazel build system, consolidating all Go modules into a single workspace with unified dependency management.

  • Consolidates three separate Go modules into a single workspace with shared dependency management
  • Replaces Docker multi-stage builds with Bazel's native Go rules and OCI container building
  • Removes Gmail functionality from the meals service, simplifying to SES-only email sending

Reviewed Changes

Copilot reviewed 43 out of 49 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
go.mod Consolidates modules and updates Go version to 1.23.0 with shared dependencies
deps.go Adds dependency resolution helper for Bazel build system
MODULE.bazel Defines Bazel workspace with Go SDK, OCI rules, and dependency management
BUILD.bazel files Replaces Dockerfiles with Bazel build rules for all containers
containers/meals-go/ Updates import paths and removes Gmail functionality
containers/garage-go/ Migrates from separate module to shared workspace
containers/flight-tracker-go/ Migrates from separate module to shared workspace
Comments suppressed due to low confidence (3)

go.mod:3

  • Go version 1.23.0 does not exist. The latest stable Go version as of my knowledge cutoff is 1.22.x. Consider using a valid Go version like 1.22.3 or 1.21.x.
go 1.23.0

go.mod:5

  • Go toolchain version 1.23.11 does not exist. This should match a valid Go toolchain version that corresponds to the Go version specified above.
toolchain go1.23.11

MODULE.bazel:10

  • Go SDK version 1.23.11 does not exist. This version should be updated to match a valid Go release version.
go_sdk.download(version = "1.23.11")

deps.go Outdated
Comment on lines 1 to 3
// Package main provides a placeholder to establish direct dependencies
// This file ensures that all required dependencies are properly resolved
// for the Bazel build system.
Copy link

Copilot AI Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package comment incorrectly states this is 'package main' but the actual package declaration on line 4 is 'package main'. However, this file appears to be a dependency resolution helper and the main function should not be called. Consider documenting this more clearly to avoid confusion about the file's purpose.

Suggested change
// Package main provides a placeholder to establish direct dependencies
// This file ensures that all required dependencies are properly resolved
// for the Bazel build system.
// Package main is a dependency resolution helper for the Bazel build system.
// This file ensures that all required dependencies are properly resolved.
// The main function is a placeholder and is not intended to be executed.

Copilot uses AI. Check for mistakes.
const (
Gmail = iota
SES
SES = iota
Copy link

Copilot AI Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the 'Gmail' constant from the EmailService enum and keeping only 'SES = iota' changes the enum value from 1 to 0. This could break existing configurations or stored values that expect Gmail=0 and SES=1. Consider maintaining backward compatibility or documenting this breaking change.

Suggested change
SES = iota
Gmail EmailService = 0
SES EmailService = 1

Copilot uses AI. Check for mistakes.
@andrewpollack andrewpollack enabled auto-merge (squash) July 28, 2025 19:13
@andrewpollack andrewpollack merged commit 58a8322 into main Jul 28, 2025
3 checks passed
@andrewpollack andrewpollack deleted the add-bazel branch July 28, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant