Repository navigation
screenshot: forward GetDeviceQueue2 to driver instead of GetDeviceQueue - #42
Merged
olehkuznetsov merged 1 commit intoOct 8, 2026
Conversation
screenshot::GetDeviceQueue2 previously stripped VkDeviceQueueInfo2::flags and pNext by forwarding to screenshot::GetDeviceQueue. When an application or ANGLE creates queues with non-zero flags (such as VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT), vkGetDeviceQueue fails to match the queue in the ICD and writes VK_NULL_HANDLE into *pQueue, causing a null-pointer dereference in Android's libvulkan.so (vulkan::driver::GetDeviceQueue) and polluting the layer's queue set with VK_NULL_HANDLE. Forward GetDeviceQueue2 directly to pDisp->GetDeviceQueue2 and guard queue registration against VK_NULL_HANDLE in both GetDeviceQueue and GetDeviceQueue2. BUG=571072981
jimblacklercorp
requested review from
m--koma and
olehkuznetsov
and removed request for
m--koma
October 7, 2026 15:48
olehkuznetsov
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
screenshot::GetDeviceQueue2 previously stripped VkDeviceQueueInfo2::flags and pNext by forwarding to screenshot::GetDeviceQueue. When an application or ANGLE creates queues with non-zero flags (such as VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT), vkGetDeviceQueue fails to match the queue in the ICD and writes VK_NULL_HANDLE into *pQueue, causing a null-pointer dereference in Android's libvulkan.so (vulkan::driver::GetDeviceQueue) and polluting the layer's queue set with VK_NULL_HANDLE.
Forward GetDeviceQueue2 directly to pDisp->GetDeviceQueue2 and guard queue registration against VK_NULL_HANDLE in both GetDeviceQueue and GetDeviceQueue2.
BUG=571072981