Repository navigation
layersvt: Set clock id and pid on DebugMarker name packets - #45
Merged
olehkuznetsov merged 1 commit intoOct 19, 2026
Merged
Conversation
jimblacklercorp
approved these changes
Oct 16, 2026
olehkuznetsov
force-pushed
the
pr-debugmarker-clock-pid
branch
from
October 19, 2026 09:10
6b4218f to
2c4a028
Compare
DebugMarker writes object names as raw packets on the track event sequence, whose defaults declare an incremental clock. The absolute boot time timestamp carried no clock id, so trace_processor read it as a delta and object names landed far past the end of the trace. Tag the timestamp with the track event clock instead. Also set pid so trace_processor can attribute names to the emitting process, and share the packet code between both emit paths. Bug: Test: new tests - DebugMarkerTests#ObjectNamePacketFieldsTest Change-Id: I9e139c138bb2c09f0b25a6ceef19e9296a6a6964
olehkuznetsov
force-pushed
the
pr-debugmarker-clock-pid
branch
from
October 19, 2026 09:18
2c4a028 to
31f5e38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DebugMarker writes object names as raw packets on the track event
sequence, whose defaults declare an incremental clock. The absolute
boot time timestamp carried no clock id, so trace_processor read it
as a delta and object names landed far past the end of the trace.
Tag the timestamp with the track event clock instead.
Also set pid so trace_processor can attribute names to the emitting
process, and share the packet code between both emit paths.
Bug:
Test: existing
Change-Id: I9e139c138bb2c09f0b25a6ceef19e9296a6a6964