Repository navigation
layersvt: Key DebugMarker object names by device - #46
Open
olehkuznetsov wants to merge 1 commit into
Open
olehkuznetsov wants to merge 1 commit into
olehkuznetsov wants to merge 1 commit into
Conversation
olehkuznetsov
force-pushed
the
pr-debugmarker-device-key
branch
from
October 19, 2026 09:12
fd5e79b to
317d9f9
Compare
Non-dispatchable handles are only unique within their VkDevice, so two devices in one process can return the same handle value. Naming an object on one device overwrote the name of an unrelated object on another, and the lost name was missing from later session replays. Key stored names by device as well as object type and handle. Bug: Test: new tests - DebugMarkerTests#SameHandleOnDifferentDevicesTest Change-Id: I8c0edd4d958451aebf1fbd17df1cb0cb6a6a6964
olehkuznetsov
force-pushed
the
pr-debugmarker-clock-pid
branch
from
October 19, 2026 09:18
6b4218f to
31f5e38
Compare
olehkuznetsov
force-pushed
the
pr-debugmarker-device-key
branch
from
October 19, 2026 09:18
317d9f9 to
ce7f840
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-dispatchable handles are only unique within their VkDevice, so
two devices in one process can return the same handle value. Naming
an object on one device overwrote the name of an unrelated object on
another, and the lost name was missing from later session replays.
Key stored names by device as well as object type and handle.
Bug:
Test: new tests - DebugMarkerTests#SameHandleOnDifferentDevicesTest
Change-Id: I8c0edd4d958451aebf1fbd17df1cb0cb6a6a6964