Repository navigation
layersvt: Remove DebugMarker object names on destruction - #48
Open
olehkuznetsov wants to merge 1 commit into
Open
olehkuznetsov wants to merge 1 commit into
olehkuznetsov wants to merge 1 commit into
Conversation
olehkuznetsov
changed the base branch from
main
to
pr-debugmarker-remove-on-null
October 15, 2026 16:06
DebugMarker kept object names until the device was destroyed. Drivers can reuse handle values for new objects, so a new resource inherited the stale name and trace consumers misattributed it. Erase an object's name when its destroy or free command is called, before dispatching downstream, so a handle reused by another thread cannot pick up the old name. Extension destroy commands are intercepted only when the device exposes them. Bug: Test: new tests - DebugMarkerTests#DestroyedObjectNamesRemovedTest, DebugMarkerTests#DestroyedObjectNamesOfOtherTypesRemovedTest, DebugMarkerTests#ExtensionDestroyCommandRequiresDownstreamTest Change-Id: Iad9147fca27b76c329450f0b9f01802a6a6a6964
olehkuznetsov
force-pushed
the
pr-debugmarker-remove-on-null
branch
from
October 19, 2026 09:18
74e9e95 to
06f55a3
Compare
olehkuznetsov
force-pushed
the
pr-debugmarker-remove-on-destroy
branch
from
October 19, 2026 09:18
277b75d to
e12a3c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DebugMarker kept object names until the device was destroyed. Drivers
can reuse handle values for new objects, so a new resource inherited
the stale name and trace consumers misattributed it.
Erase an object's name when its destroy or free command is called,
before dispatching downstream, so a handle reused by another thread
cannot pick up the old name. Extension destroy commands are
intercepted only when the device exposes them.
Bug:
Test: new tests - DebugMarkerTests#DestroyedObjectNamesRemovedTest, DebugMarkerTests#DestroyedObjectNamesOfOtherTypesRemovedTest, DebugMarkerTests#ExtensionDestroyCommandRequiresDownstreamTest
Change-Id: Iad9147fca27b76c329450f0b9f01802a6a6a6964