Repository navigation
vulkan: Fix queue retrieval and family selection for frame warm up - #33
Merged
Merged
Conversation
When initializing VulkanFrameWarmUp, vkGetDeviceQueue was previously called directly with hardcoded family 0 and queue 0. If the application created the device with queue flags (such as VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT) or non-zero family indices, calling vkGetDeviceQueue causes a crash in Vulkan drivers (such as on Android). This change: - Uses FindComputeQueueFamilyIndex to find the compute-capable queue family. - Uses GetDeviceQueue helper to properly dispatch vkGetDeviceQueue2 when queue creation flags are present. - Sets cmd_pool_info.queueFamilyIndex to the resolved queue family.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initializing
VulkanFrameWarmUp,vkGetDeviceQueuewas previously called directly with hardcoded family 0 and queue 0.If the application created the device with queue flags (such as
VK_DEVICE_QUEUE_CREATE_PROTECTED_BIT) or non-zero family indices, callingvkGetDeviceQueuecauses a crash in Vulkan drivers (such as on Android).This change:
FindComputeQueueFamilyIndexto find the compute-capable queue family.GetDeviceQueuehelper fromdecoder_util.hto properly dispatchvkGetDeviceQueue2when queue creation flags are present.cmd_pool_info.queueFamilyIndexto the resolved compute queue family.