Skip to content

Sync changes from internal dev branch.#87

Merged
kaishi05 merged 3 commits intomainfrom
copybara_HEAD
Apr 2, 2026
Merged

Sync changes from internal dev branch.#87
kaishi05 merged 3 commits intomainfrom
copybara_HEAD

Conversation

@lip-liu
Copy link
Copy Markdown
Collaborator

@lip-liu lip-liu commented Apr 2, 2026

No description provided.

lip-liu added 3 commits April 2, 2026 21:56
PiperOrigin-RevId: 892354630
PiperOrigin-RevId: 892959815
PiperOrigin-RevId: 893673111
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the regex pattern in betocq/setup_utils.py to accommodate additional characters in the RSSI field. A review comment suggests using a more robust non-whitespace matcher (\S+) since the field is skipped and not captured, which would prevent future breakages from unexpected output formats.

(\d+) # Captures Frequency
\s+
[-\d.]+ # Matches RSSI (skipped)
[-\d()./:]+ # Matches RSSI (skipped)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The regex for the RSSI field is being expanded to include more characters, but it remains brittle as it still excludes alphabetic characters (e.g., for 'N/A' or 'unknown' values) and other potential punctuation. Since this field is explicitly skipped and not captured, using \S+ (matching any non-whitespace characters) would be more robust and maintainable, preventing the need for future updates when encountering different output formats from various devices.

Suggested change
[-\d()./:]+ # Matches RSSI (skipped)
\S+ # Matches RSSI (skipped)

@kaishi05 kaishi05 merged commit 237fd4f into main Apr 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants